Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:community-banner #21

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

zleypner
Copy link

@zleypner zleypner commented Dec 14, 2024

Community Banner Component Implementation

Description

Creating a new Community Banner component that will display community information in a standardized format.

Component Requirements

  • Community icon/shape display
  • Community name text display
  • "More info" interactive button
  • Member count display

Design Specifications

Color Palette

  • Primary Background: #4ECCA3
  • Secondary Background: #387478
  • Dark Text/Icon: #232931
  • Accent: #E36C59
  • Base Background: #EEEEEE

Tasks

  • Create basic component structure
  • Implement responsive layout
  • Add icon/shape placeholder
  • Style component according to color palette
  • Add hover/interactive states for "More info" button
  • Add proper typings
  • Write component tests
  • Add documentation
  • Add accessibility features

Testing Checklist

  • Component renders with all required props
  • Button click handler works as expected
  • Responsive behavior works on different screen sizes

Screenshots

Pending

Related Issue: #15

Thank for reviewing my PR!

@zleypner
Copy link
Author

zleypner commented Dec 14, 2024

🚧 Work in Progress: I am working on this issue and will update with implementation progress ASAP ⚡

@zleypner
Copy link
Author

🚧 Work in Progress: Just updated the initial implementation!

🎨 Still working on improving the design and polishing the UI

🔄 Will continue to update with more progress soon ⚡

@zleypner
Copy link
Author

zleypner commented Dec 17, 2024

Hello there!
I just uploaded an update. I would appretiate some feedback.

Would you like to move the sidebar under the banner?
image

@zleypner
Copy link
Author

zleypner commented Dec 17, 2024

This is the current view for the banner:
I added a shadow for the members at the right hand.
Would you like to keep it or remove it?
image

Would you like to change the color for the Hover?
image

@zleypner zleypner marked this pull request as ready for review December 18, 2024 01:38
@evgongora evgongora self-requested a review December 18, 2024 14:36
@evgongora
Copy link
Collaborator

Hello there! I just uploaded an update. I would appretiate some feedback.

Would you like to move the sidebar under the banner? image

Right now we just need the component to be created, no need to be added in the layout, so you can go ahead and remove it for now. Thank you!

@evgongora
Copy link
Collaborator

After that we can go ahead and merge it.

@zleypner
Copy link
Author

zleypner commented Dec 18, 2024

Thank you @evgongora , I will!
I will proceed with the updates asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants