Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

int-679 Skip empty lines from the parsing #27

Merged
merged 2 commits into from
Apr 24, 2024

int-679 code review feedbacks

1aed1e9
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

int-679 Skip empty lines from the parsing #27

int-679 code review feedbacks
1aed1e9
Select commit
Loading
Failed to load commit list.
GitHub Actions / UT Report succeeded Apr 24, 2024 in 0s

UT Report ✅

Tests passed successfully

✅ /home/src/magicparse/reports/unit_tests_results.xml

130 tests were completed in 271ms with 130 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
pytest 130✅ 271ms

✅ pytest

tests.test_builders.TestBuild
  ✅ test_no_name_provided
  ✅ test_unknown
  ✅ test_with_parameter
  ✅ test_without_parameter
tests.test_builders.TestConcat
  ✅ test_concat_integer
  ✅ test_concat_three_fields
  ✅ test_concat_two_fields
  ✅ test_empty_params
  ✅ test_field_not_present
  ✅ test_fields_params_empty
  ✅ test_fields_params_has_less_than_two_field
  ✅ test_fields_params_not_a_list_of_str
  ✅ test_no_params
tests.test_builders.TestDivide
  ✅ test_denominator_not_valid
  ✅ test_denominator_param_empty
  ✅ test_empty_params
  ✅ test_field_not_present
  ✅ test_no_params
  ✅ test_numerator_not_valid
  ✅ test_numerator_param_empty
  ✅ test_valid_param
tests.test_builders.TestMultiply
  ✅ test_empty_params
  ✅ test_field_not_present
  ✅ test_no_params
  ✅ test_valid_param
  ✅ test_x_factor_param_empty
  ✅ test_x_y_factor_not_valid
  ✅ test_y_factor_param_empty
tests.test_computed_fields.TestBuild
  ✅ test_bad_value_for_builder
  ✅ test_error_format
  ✅ test_not_iterable_value_for_builder
  ✅ test_with_valid_builder
  ✅ test_without_builder
tests.test_encodings.TestCsvEncoding
  ✅ test_default_encoding
  ✅ test_exotic_encoding
tests.test_encodings.TestExoticEncoding
  ✅ test_default_encoding
  ✅ test_exotic_encoding
tests.test_fields
  ✅ test_chain_transformations
  ✅ test_chain_transformations_with_post_processors
  ✅ test_csv_error_format
  ✅ test_columnar_error_format
  ✅ test_optional_field
  ✅ test_required_field
  ✅ test_require_field_with_empty_value
tests.test_post_processors.TestBuild
  ✅ test_divide
  ✅ test_no_name_provided
  ✅ test_unknown
tests.test_post_processors.TestDivide
  ✅ test_divide_decimal
  ✅ test_divide_float
  ✅ test_divide_int
  ✅ test_fail_when_denominator_is_zero
tests.test_post_processors.TestRound
  ✅ test_with_negative_precision
  ✅ test_with_valid_precision
tests.test_post_processors.TestRegister
  ✅ test_register
tests.test_pre_processors.TestBuild
  ✅ test_left_pad_zeroes
  ✅ test_left_strip
  ✅ test_map
  ✅ test_no_name_provided
  ✅ test_regex_extract
  ✅ test_replace
  ✅ test_strip_whitespaces
  ✅ test_unknown
tests.test_pre_processors.TestLeftPadZeroes
  ✅ test_do_nothing
  ✅ test_pad
tests.test_pre_processors.TestMap
  ✅ test_known_input
  ✅ test_unknown_input
tests.test_pre_processors.TestReplace
  ✅ test_pattern_not_found
  ✅ test_success
tests.test_pre_processors.TestStripWhitespaces
  ✅ test_do_nothing
  ✅ test_success
tests.test_pre_processors.TestLeftStrip
  ✅ test_do_nothing
  ✅ test_success
tests.test_pre_processors.TestRegexExtract
  ✅ test_build_without_value_group
  ✅ test_pattern_found
  ✅ test_pattern_not_found
tests.test_pre_processors.TestRegister
  ✅ test_register
tests.test_schema.TestBuild
  ✅ test_columnar
  ✅ test_csv_with_hdelimiter
  ✅ test_csv_with_header
  ✅ test_default_csv_schema
  ✅ test_unknwown
tests.test_schema.TestCsvParse
  ✅ test_error_display_row_number
  ✅ test_errors_do_not_halt_parsing
  ✅ test_parse_should_skip_empty_lines
  ✅ test_with_header
  ✅ test_with_no_data
  ✅ test_with_no_field_definition
  ✅ test_without_header
tests.test_schema.TestColumnarParse
  ✅ test_error_display_row_number
  ✅ test_errors_do_not_halt_parsing
  ✅ test_parse
  ✅ test_parse_should_skip_empty_lines
  ✅ test_with_no_data
  ✅ test_with_no_field_definition
tests.test_schema.TestQuotingSetting
  ✅ test_asymetrical_quote
  ✅ test_double_quote
  ✅ test_no_quote
  ✅ test_single_quote
tests.test_schema.TestRegister
  ✅ test_register
tests.test_schema.TestSteamParse
  ✅ test_stream_parse_errors_do_not_halt_parsing
tests.test_type_converters.TestBuild
  ✅ test_datetime
  ✅ test_decimal
  ✅ test_int
  ✅ test_no_type_provided
  ✅ test_str
  ✅ test_time
  ✅ test_unknown
tests.test_type_converters.TestStr
  ✅ test_apply
tests.test_type_converters.TestInt
  ✅ test_apply
  ✅ test_apply_failed
tests.test_type_converters.TestDecimal
  ✅ test_apply
  ✅ test_apply_failed
tests.test_type_converters.TestTime
  ✅ test_apply
  ✅ test_apply_failed
  ✅ test_apply_naive_time
tests.test_type_converters.TestDateTime
  ✅ test_apply
  ✅ test_apply_failed
  ✅ test_apply_naive_time
tests.test_type_converters.TestRegister
  ✅ test_register
tests.test_validators.TestBuild
  ✅ test_greater_than_params_are_correct
  ✅ test_no_name_provided
  ✅ test_regex_matches
  ✅ test_unknown
tests.test_validators.TestRegexMatches
  ✅ test_does_not_match
  ✅ test_match
tests.test_validators.TestRegister
  ✅ test_register
tests.test_validators.TestGreaterThanValidator
  ✅ test_it_raises_an_error_when_the_value_is_equal_to_threshold
  ✅ test_it_raises_an_error_when_the_value_is_lower_than_threshold
  ✅ test_it_successfully_returns_the_value_when_greater_than_decimal_threshold
  ✅ test_it_successfully_returns_the_value_when_greater_than_threshold