Skip to content

Commit

Permalink
add comment
Browse files Browse the repository at this point in the history
  • Loading branch information
JEnoch committed Nov 22, 2024
1 parent 358716c commit 3503c47
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions rmw_zenoh_cpp/src/detail/rmw_publisher_data.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,11 @@ std::shared_ptr<PublisherData> PublisherData::make(

if (adapted_qos_profile.reliability == RMW_QOS_POLICY_RELIABILITY_RELIABLE) {
opts.reliability = Z_RELIABILITY_RELIABLE;
// Note: Unlike DDS which blocks the Publisher only if QoS is RELIABLE + KEEP_ALL,
// we configure Zenoh to block for any RELIABLE Publisher.
// The reason being that over congested networks (where Zenoh is often used) the default
// behaviour would often lead to message losses, which could be problematic in the
// case of a "latched topic" (RELIABLE, TRANSIENT_LOCAL, KEEP_LAST(1), only 1 publication)
opts.congestion_control = Z_CONGESTION_CONTROL_BLOCK;
}
z_owned_publisher_t pub;
Expand Down

0 comments on commit 3503c47

Please sign in to comment.