Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels: reserve updates #2535

Merged
merged 3 commits into from
Nov 16, 2024
Merged

Channels: reserve updates #2535

merged 3 commits into from
Nov 16, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Nov 16, 2024

Description

This PR builds off of the work to highlight channel reserves in #2522

Previously, sending capacity for a channel was calculated incorrectly.

Now:

  • Sending and receiving capacities displayed correctly
  • Local balance and remote balances are displayed separately on the single Channel view above sending and receiving capacities
  • Local balance and local reserve and highlighted in red when the local balance does not exceed the local reserve
  • ChannelItem on the Channels list view and HopPicker displays the local balance instead of the sending capacity, and highlights it in red when the local balance does not exceed the local reserve
  • Alias SCIDs moved above the Channel balance section on the single Channel view

Simulator Screenshot - iPhone 16 Plus - 2024-11-15 at 20 38 21
Simulator Screenshot - iPhone 16 Plus - 2024-11-15 at 20 38 37
Simulator Screenshot - iPhone 16 Plus - 2024-11-15 at 20 38 57
Simulator Screenshot - iPhone 16 Plus - 2024-11-15 at 20 42 14

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.9.3 milestone Nov 16, 2024
@kaloudis
Copy link
Contributor Author

New variant with a softer red:

simulator_screenshot_0CBE8917-7A4C-4CF1-84EF-06AF97020648
simulator_screenshot_5ABFE41E-AD2A-4E78-9BDA-AA7E20E7D604

@kaloudis kaloudis merged commit 78370c3 into ZeusLN:master Nov 16, 2024
4 checks passed
@kaloudis kaloudis deleted the reserve-updates branch November 16, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant