Skip to content

Commit

Permalink
Merge pull request Expensify#35065 from JKobrynski/migrateWorkspaceMe…
Browse files Browse the repository at this point in the history
…mbersPageToTypeScript

[TS migration] Migrate 'WorkspaceMembers' page to TypeScript
  • Loading branch information
tgolen authored Feb 22, 2024
2 parents 143d88b + b0eb670 commit fa55c40
Show file tree
Hide file tree
Showing 4 changed files with 159 additions and 185 deletions.
2 changes: 1 addition & 1 deletion src/components/SelectionList/BaseSelectionList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ function BaseSelectionList<TItem extends ListItem>(
showTooltip={showTooltip}
canSelectMultiple={canSelectMultiple}
onSelectRow={() => selectRow(item)}
onDismissError={onDismissError}
onDismissError={() => onDismissError?.(item)}
shouldPreventDefaultFocusOnSelectRow={shouldPreventDefaultFocusOnSelectRow}
rightHandSideComponent={rightHandSideComponent}
keyForList={item.keyForList}
Expand Down
2 changes: 1 addition & 1 deletion src/components/SelectionList/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ type BaseSelectionListProps<TItem extends ListItem> = Partial<ChildrenProps> & {
onSelectAll?: () => void;

/** Callback to fire when an error is dismissed */
onDismissError?: () => void;
onDismissError?: (item: TItem) => void;

/** Label for the text input */
textInputLabel?: string;
Expand Down
2 changes: 1 addition & 1 deletion src/libs/PolicyUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ function shouldShowPolicy(policy: OnyxEntry<Policy>, isOffline: boolean): boolea
);
}

function isExpensifyTeam(email: string): boolean {
function isExpensifyTeam(email: string | undefined): boolean {
const emailDomain = Str.extractEmailDomain(email ?? '');
return emailDomain === CONST.EXPENSIFY_PARTNER_NAME || emailDomain === CONST.EMAIL.GUIDES_DOMAIN;
}
Expand Down
Loading

0 comments on commit fa55c40

Please sign in to comment.