-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update website and zine (Zig 0.13) and fix broken links #229
Conversation
MatthiasPortzel
commented
Aug 1, 2024
•
edited
Loading
edited
- Updates Zine for Zig 0.13
- Frontmatter format changed to zon from JSON
- Requires valid HTML—no self closing tags
- Updated broken links
- regz and uf2 now point to the monorepo folder
- Dropped the extension from the "Getting Started" link, that's now fixed
- The Getting Started page needed some absolute links to assets since it's now a folder not a top-level file
- Updated the ziglings link to point to Codeberg
- Deleted the "legacy-ssg" folder (hopefully that wasn't still needed)
@EliSauder I think this duplicates some work you did previously, does this look right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only last thing other than the other comments, is the layout files should be moved to .shtml over .html as that is the file extension kristoff chose for the SuperHTML templating language.
.url = "git+https://github.com/kristoff-it/zine#e21b179b78de54ab48efe38d2378e87a56cb3542", | ||
.hash = "1220781f118454bbc87d7efbd244b4d1ef029e76a6113ddf4752a6f3cd85879dbb3b", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest going with the tagged release since kristoff has made one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the Zig package system to know what advantage we get from using a different URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main version is using a well defined release version that the library creator has determined is good to go rather than a specific commit. If we want to stick with a commit that is alright, I just think using explicit versions tends to make more sense to me. Using zon, you can do something like ...#v0.4.1 as the # just expects a particular git ref.
Also this won't automatically deploy to the website yet since the workflows are broken (what I've been working on updating). So this should probably wait until that gets merged in to main. |
Also also, we probably want to wait for the asset system redesign that kristoff is working on (should be done somewhat soon). |
Resolves ZigEmbeddedGroup/website#13 |
Nice work! |
@EliSauder: Merging this should be fine with your changes, right? |
Yeah, i just rebased some of the changes so there shouldn't be any conflicts. |
@ikskuh the only remaining concern for the website is that zine has been updated. But we could have that be its own PR. |
Yeah, sounds like a good idea :) |