-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rp2xxx: Add support for assembling RP2350-specific PIO #320
Draft
Grazfather
wants to merge
14
commits into
ZigEmbeddedGroup:main
Choose a base branch
from
Grazfather:rp2350_pio_assembler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
rp2xxx: Add support for assembling RP2350-specific PIO #320
Grazfather
wants to merge
14
commits into
ZigEmbeddedGroup:main
from
Grazfather:rp2350_pio_assembler
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
commented
Dec 19, 2024
}; | ||
} | ||
|
||
pub fn assemble(comptime format: Format, comptime source: []const u8, comptime options: AssembleOptions) Output { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to make the user provide the format
Grazfather
force-pushed
the
rp2350_pio_assembler
branch
2 times, most recently
from
December 19, 2024 21:21
12680f8
to
6355e52
Compare
Grazfather
force-pushed
the
rp2350_pio_assembler
branch
from
December 20, 2024 20:29
6355e52
to
648c840
Compare
Grazfather
changed the title
rp2xxx: Add support for rp2350 assembling
rp2xxx: Add support for assembling RP2350-specific PIO
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RP2350 adds the following new instruction features:
PINDIRS, ~NULL
blocks.
machines on the next cycle.
scratch register.
RP2350 adds the following security features:
Secure GPIO returns a 0.
permit Non-secure access according to ACCESSCTRL) and Secure-only blocks (those which do not).
RP2350 includes the following general improvements: