Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Old/Extra Files #333

Merged
merged 6 commits into from
Dec 27, 2024
Merged

Conversation

EliSauder
Copy link
Contributor

Did a pass through of the repo removing extra license files and some files that are remaining from moving to a monorepo.

This mirrors the cleanup changes I made in the original workflows update PR (#232) but this is a separate PR to implement the changes.

@mattnite
Copy link
Contributor

@EliSauder The license files exist so that they are included in distributed tarballs.

@EliSauder
Copy link
Contributor Author

@EliSauder The license files exist so that they are included in distributed tarballs.

@mattnite I see, but won't we generally be distributing it as a single tarball from the output for boxzer? In which case wouldn't the idea of just having the root one be fine (Also a note on this, I just checked the boxzer output and at the moment the root tar doesn't have a LICENSE file, not sure if this is intentional or not)?

@mattnite
Copy link
Contributor

@EliSauder the tarball in the release is effectively saved state of the packages for a version, it exists for the deployment for the pages site which iterates releases, grabs these, and extracts them for the downloads folder. The License files are needed for each package tarball, and and these are stored in that boxzer-out tarball

@EliSauder
Copy link
Contributor Author

@mattnite I think I understand now. But regardless of my full understanding, I have reverted those changes.

@mattnite mattnite merged commit cec1b0d into ZigEmbeddedGroup:main Dec 27, 2024
27 checks passed
@EliSauder EliSauder deleted the repo-cleanup branch December 27, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants