Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build, improve reloader, API #32

Merged

Conversation

SuperAuguste
Copy link
Collaborator

No description provided.

@JerwuQu
Copy link
Contributor

JerwuQu commented May 2, 2024

Here are some issues and ideas for improvements I've discovered.
Will keep updated as I keep poking around.

API

  • blit src_x/src_y mismatch i32/u32 with the platform_specific one leading to a compiler error
  • text_color for text should be optional
  • blit flags should have a default
  • Functions that take optionals in structs should default them to null
  • red/green/blue => r/g/b since names are implicit when the type is a color
  • Controls should preferably have a backing int

Watcher

  • Watcher should build once directly when running zig build watch
  • unable to check cache: stat file '(ROOT)/src/cart.ld' failed: FileNotFound errors when running zig build watch
  • Placing the zig root source file in the root (rather than e.g. a src/ subdir) will cause the watcher to watch all files in the whole root dir, including zig-cache which causes errors and breaking the watcher whenever the cache changes
  • watcher is finicky if wanting to have auto-converted assets because source assets should be watched but output assets shouldn't

Sim

  • Out of bounds memory error goes off screen
  • npm run dev should build and live-reload It seems to work. Maybe something was wrong on my end...

@SuperAuguste SuperAuguste marked this pull request as ready for review May 3, 2024 22:38
@mattnite mattnite merged commit 4a27074 into ZigEmbeddedGroup:main May 4, 2024
5 checks passed
@SuperAuguste SuperAuguste deleted the auguste/more-sim-improvements branch May 6, 2024 12:28
@JerwuQu JerwuQu mentioned this pull request May 8, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants