Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZIL-5471: Bridge Improvements #276

Merged
merged 2 commits into from
Nov 14, 2023
Merged

ZIL-5471: Bridge Improvements #276

merged 2 commits into from
Nov 14, 2023

Conversation

WuBruno
Copy link
Contributor

@WuBruno WuBruno commented Nov 14, 2023 •
edited
Loading

Massive overhaul for the bridge:

  • Migrated back to npm, pnpm was complaining too much with hardhat
  • Improved the use of ethers
  • Introduced Create2 to Relayer to deploy new bridged contracts
  • Fixed problems related to tests
  • reorganised contract files
  • separated the Collector from the Relayer
  • improved usability and efficiency of validating signatures on-chain against validators on-chain
  • Created ValidatorManager contract to handle everything related to maintaining validators
  • Allow tests to run seamlessly by created 2 hardhat chains running in the background

DrZoltanFazekas
DrZoltanFazekas approved these changes Nov 14, 2023
View reviewed changes
products/bridge/test/test.ts Show resolved Hide resolved
products/bridge/test/test.ts Show resolved Hide resolved
products/bridge/test/test.ts Show resolved Hide resolved
products/bridge/test/utils.ts Show resolved Hide resolved
products/bridge/test/utils.ts Show resolved Hide resolved
products/bridge/test/utils.ts Show resolved Hide resolved
@WuBruno WuBruno merged commit b49f3e7 into main Nov 14, 2023
10 of 11 checks passed
@WuBruno WuBruno deleted the bridge-improvements branch November 14, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrZoltanFazekas DrZoltanFazekas DrZoltanFazekas approved these changes

@theo-zil theo-zil Awaiting requested review from theo-zil

@troelsfr troelsfr Awaiting requested review from troelsfr

@JamesHinshelwood JamesHinshelwood Awaiting requested review from JamesHinshelwood

@rrw-zilliqa rrw-zilliqa Awaiting requested review from rrw-zilliqa rrw-zilliqa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WuBruno @DrZoltanFazekas