Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APT-1653: ZQ2 protomainnet connected #738

Merged
merged 2 commits into from
Jan 22, 2025
Merged

APT-1653: ZQ2 protomainnet connected #738

merged 2 commits into from
Jan 22, 2025

Conversation

lukozill
Copy link
Contributor

@lukozill lukozill commented Jan 20, 2025

Description

Functional changes:

  • Zillion now recognizes when ZilPay is connected to Protomainnet and uses the appropriate configuration
  • Blockchain data loading split into multiple steps, so now it does not look broken cause of long fetching times
  • In case of loading errors (e.g., API unresponsive), the webpage now indicates that

Minor changes:

  • Config for ZQ2 protomainnet added to all cloud stages. So, after deployment, everybody can test on https://stake.zilliqa.com
  • Network configuration improved. Recognition is now based on the API URL instead of the ZilPay network name to enable proto networks. The code got refactored, so most of the things are now hardcoded in config-helper.ts
  • blockchain_explorer_config removed. This was redundant as we are only using one explorer per chain.
  • Zilliqa API instance creation code simplified (e.g., ApiRandomize removed)
  • console.warn replaced with console.error so we actually see the errors

Testing

  • The npm run build works
  • I've tested the application with ZilPay connected to ZQ2 Protomainnet. I was able to stake. I couldn't do unstaking, but that looks like an issue with the Network, not the application. Therefore, we can merge this one, as it delivers value beyond just adding ZQ2 Protomainnet.

@lukozill lukozill requested a review from rrw-zilliqa as a code owner January 20, 2025 13:04
@lukozill lukozill enabled auto-merge (squash) January 22, 2025 11:01
@lukozill lukozill merged commit 966768d into main Jan 22, 2025
6 checks passed
@lukozill lukozill deleted the APT-1653 branch January 22, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants