This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
AS5048A-Arduino #7
Open
Dmitry-Chernikov
wants to merge
88
commits into
ZoetropeLabs:master
Choose a base branch
from
Dmitry-Chernikov:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update AS5048A.h
Thanks for all the hard work @Dmitry-Chernikov! I've thought on this a lot and I think unfortunately I cannot accept this PR because this project is in english rather than russian and I do not want to end up with bi-lingual comments. I suggest you keep your fork as a russian language version, or please feel free to re-open with english comments and I'll review. Thanks again! |
Hello, well, I will translate the comments and descriptions of the library into English, the work on the library has not yet been completed, changes will be made. |
1 similar comment
Hello, well, I will translate the comments and descriptions of the library into English, the work on the library has not yet been completed, changes will be made. |
benhowes welcome comments corrected. |
Set the default values only in the header file (AS5048A.H), and in the implementation file (AS5048A.CPP), remove them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added calculation of the average median of 16 measurements (algorithm).
Modernized Read and Write functions.
Added features:
//Returns the physical quantity in angular degrees, obtained from a binary 14 bit ADC number
//Returns the physical quantity in angular radians, obtained from the binary 14-bit ADC number
//Returns the incremental and decrementing rotation angle in the variable RotationAngle. The variable addresses are passed to the procedure.
//Returns the angle minutes
//Returns seconds of angle
//Returns the movement of the spur gear in mm
//Returns the movement of the screw in mm
//Function to sort ascending
//The function sends the NOP command and returns the contents of the register. The NOP team is a fake write to register x0000 sensor AS5048
//The procedure records the absolute value measured by the sensor AS5048, a randomly located magnet on the axis of rotation, as zero angle position
//Set the zero position
//Returns the current zero position
//Get and clear the error register and output the register value to the Serial port