New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some minor bugfixes and code clarifications #3

Open

saeub wants to merge 4 commits into ZurichNLP:master from saeub:master

saeub commented Jun 21, 2019

fixed a TensorFlow InvalidArgumentError when source and target vocabularies have different sizes (e.g. when training on the 10k EN/ES test set in the repo)
create model and logs directories before using the logger the first time (this caused daikon to crash when logs didn't exist)
updated some names and removed Vocabulary.get_random_id(), which were probably remnants from romanesco?
added and corrected some type hints

saeub added 4 commits

June 21, 2019 21:12


          fix bug for vocabs smaller than max_size

a03976d


          create log directories before setting up logger


          remove some romanesco remnants

aace57b


          clear up some confusing bits

6b49187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet