Updates needed for rebuilding docker image #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to rebuild the docker image to run some containers and found a few changes were needed.
Github deprecated anonymous cloning using
[email protected]:user/project.git
urls. So replaced it with the https equivalent for the submodule.The
python:3.6
base image is not supported anymore because the base operating system is EOL. So replaced it withpython:3.7
which I hope will not mean any big changes in behaviour python-wise. The switch of base image comes with an upgradedgcc
which makesbwa
building unhappy. So I used an explicit option forgcc
duringmake
. That is a known issue withbwa
and stole the solution frombwa
github
issues. Also with the switch to python I had to upgrade versions of some of your python dependencies. I tried to upgrade things just enough to keep things compatible.Also added some cleaning for
apt
to try to reduce the resulting image. That should have no impact in functionality but help to produce a slightly smaller image. And apip
update which is usually good to have.We used the resulting image a couple of times and seems things are happy. But probably checking with some edge cases would be a good idea.
My neighbours here at Sanger are suggesting upgrading to a more recent
samtools
. But that will likely produce some small variations in output. So probably best to have a release with as few changes as possible and then make a release which may have breaking changes.