Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/978/css auto naming clash #996

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Issue/978/css auto naming clash #996

merged 3 commits into from
Nov 12, 2024

Conversation

GustavoSept
Copy link
Contributor

Fixes #978

  • Essentially increases the hash suffix length for any CSS class from 4 to 8.
  • Current tests adjusted to have the new hash length
  • Added one new test with 2 assertions:
    • That hash suffix length is not below 6
    • That a problematic case (when len == 4) does not result in identical hashes

garrettladley
garrettladley approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@garrettladley garrettladley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff @GustavoSept

@a-h a-h merged commit 9c8ad4d into a-h:main Nov 12, 2024
4 checks passed
@a-h
Copy link
Owner

a-h commented Nov 12, 2024

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettladley garrettladley garrettladley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: auto-generated CSS class name clashing
3 participants
@GustavoSept @a-h @garrettladley