Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugins to config the Code Snippet UI component #241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

archonwang
Copy link
Contributor

No description provided.

updated from a-ono / master
add plugins to config the Code Snippet UI component
based on
http://ckeditor.com/addon/codesnippet
@kaynz
Copy link

kaynz commented Mar 14, 2017

I'm getting this error if i apply your pull request: https://paste.xinu.at/9l9/

@archonwang
Copy link
Contributor Author

archonwang commented Mar 15, 2017

I will check it later ,please tell me what is redmine environment and browser?

@kaynz
Copy link

kaynz commented Mar 15, 2017

Environment:
  Redmine version                3.3.0.stable
  Ruby version                   2.3.3-p222 (2016-11-21) [x86_64-linux]
  Rails version                  4.2.6
  Environment                    production
  Database adapter               Mysql2

@archonwang
Copy link
Contributor Author

archonwang commented Mar 15, 2017

it seems that I have missed some config, I will check it on my Environment..

My Environment is

Environment:
Redmine version 3.3.2.stable.16399
Ruby version 2.2.4-p230 (2015-12-16) [x86_64-linux]
Rails version 4.2.7.1
Environment production
Database adapter Mysql2
CkEditor CKEditor 4.5.10 (revision b47abaf)

by the way, is there any other error occured? Thanks.

@archonwang
Copy link
Contributor Author

archonwang commented Mar 15, 2017

please check it. and the plugin code snippet should be used in ckeditor with 4.5+

http://stackoverflow.com/questions/31251357/ckeditor-tools-getindex-is-not-a-function

so, please check you ckeditor with the correct version.

@kaynz
Copy link

kaynz commented Mar 15, 2017

I checked out your master branch (commit 533835) and tried it with upper error.

@archonwang
Copy link
Contributor Author

OK,I will take a new environment to check the issue. but need some time to confirm it. Thanks for your reply.

@archonwang
Copy link
Contributor Author

archonwang commented Mar 30, 2017

@kaynz , do you have installed any other plugin?
Could you user a-ono's redmine_ckeditor master repo correctly?

I checked in my new environment, it's OK.
by the way , it conflict with the plugin named scrum2b(https://github.com/scrum2b/scrum2b)

@kaynz
Copy link

kaynz commented Mar 30, 2017

@archonwang

Redmine Plugins:

redmine_bootstrap_kit
redmine_checklists
redmine_ckeditor
redmine_lightbox2
redmine_people

No custom ckeditor plugins.

@archonwang
Copy link
Contributor Author

@kaynz
I do not install redmine_people, please tried it on new environment .

by the way, what has happened with your environment. could you give me more information for I cannot to check the error image on https://paste.xinu.at/9l9/

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants