sound DA: Add a cancel button #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been debugging my own IIe emulator lately, and I used the sound DA a lot to test it... However it was always nagging me that this modal dialog lacks a... cancel button! So I dived in, I have to say I'm very fresh to the codebase, but I tried to respect the 'style' and behaviours. Signed-off-by: Michel Pollet <[email protected]>
|
Initial review looks good. I'll test when I can. |
|
Code looked good. I might tweak the layout to move the cancel button to the left so the buttons are symmetrical, but there's not a standard layout yet. |
|
Ah I wasn't sure, I had started by putting it left, but then I remember that on old Mac's the buttons were always tucked to the right... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been debugging my own IIe emulator lately, and I used the sound DA a lot to test it... However it was always nagging me that this modal dialog lacks a... cancel button!
So I dived in, I have to say I'm very fresh to the codebase, but I tried to respect the 'style' and behaviours.