Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly install regular pip dependencies in declarative image builds #128

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

AdrianoKF
Copy link
Collaborator

@AdrianoKF AdrianoKF commented Oct 8, 2024

PR description courtesy of Copilot, let's try this thing out 😄


This pull request includes several changes to the client/src/jobq/assembler/renderers.py file to improve the handling of package dependencies and their installation in Docker images. It also updates the test suite to ensure these changes are correctly validated. The most important changes include copying the pip list to avoid modifying the original, removing processed packages from the list, and adding new assertions in the test cases to verify the Dockerfile content.

Improvements to dependency handling:

Updates to test cases:

@AdrianoKF AdrianoKF self-assigned this Oct 8, 2024
@AdrianoKF AdrianoKF linked an issue Oct 8, 2024 that may be closed by this pull request
@AdrianoKF AdrianoKF merged commit 847f265 into main Oct 8, 2024
2 checks passed
@AdrianoKF AdrianoKF deleted the 126-image-pip-deps branch October 8, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declarative image build ignores package dependencies
2 participants