Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer alternative to memcache outside docker #124

Closed
Xuzzo opened this issue Sep 12, 2022 · 2 comments · Fixed by #458
Closed

Offer alternative to memcache outside docker #124

Xuzzo opened this issue Sep 12, 2022 · 2 comments · Fixed by #458
Assignees
Labels
cleanup when code is ugly or unreadable and needs restyling enhancement New feature or request utils
Milestone

Comments

@Xuzzo
Copy link
Collaborator

Xuzzo commented Sep 12, 2022

Our data shapley methods heavily rely on memcache. On windows, the best (only?) way to use memcache is through Docker, which is a problem cause Docker is not free of charge.
In the spirit of making our repository plug and play and as independent as possible, we should offer an alternative to memcache within our utility wrapper.

@Xuzzo Xuzzo added the enhancement New feature or request label Sep 12, 2022
@AnesBenmerzoug
Copy link
Collaborator

We should probably have a Cache abstraction with multiple implementations to give ourselves and the users more flexibility and to hide away implementation details.

The most commonly used caches are, excluding Memcached, Redis for distributed settings and SQlite for in-memory or on-disk caching.

@AnesBenmerzoug AnesBenmerzoug added utils cleanup when code is ugly or unreadable and needs restyling labels Sep 20, 2022
@mdbenito
Copy link
Collaborator

mdbenito commented Dec 1, 2022

Disabling memcache by default would be a stopgap, see #210 => moving this to a later milestone

@mdbenito mdbenito removed this from the Ready for public release milestone Dec 1, 2022
@mdbenito mdbenito added this to the v0.7.0 milestone Mar 9, 2023
@AnesBenmerzoug AnesBenmerzoug self-assigned this Sep 7, 2023
@mdbenito mdbenito modified the milestones: v0.8.0, v0.7.2 Oct 26, 2023
@AnesBenmerzoug AnesBenmerzoug linked a pull request Dec 4, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup when code is ugly or unreadable and needs restyling enhancement New feature or request utils
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants