Fixes for grouped dataset #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name file to target-name
…name source-file to git-split-temp
…solve conflict and keep both files
…store name of source-file
|
@AnesBenmerzoug I'm not sure you have much time for this, so I'll merge right away and let you review post-merge if you feel like it 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes inconsistencies in how grouped dataset operates with indices and allows methods to consistently access data either via "logical indices" (those kept by
Dataset) or "data indices" (those corresponding to the data arrays themselves)Changes
data()which takes logical indices as argumentChecklist
If notebooks were added/changed, added boilerplate cells are tagged with"tags": ["hide"]or"tags": ["hide-input"]