fix: avoid random failures on tests

internal/controllers/ipcidr_controller_test.go

@@ -61,6 +61,8 @@ var _ = Describe("IPCidr controller", func() {
 				}
 				return createdIpCidr.Status.Registered, nil
 			}, timeout, interval).Should(Equal(false))
+			By("Deleting the bad cidr")
+			Expect(k8sClient.Delete(ctx, createdIpCidr)).Should(Succeed())
 
 			By("Creating a new IPCidr that overlap a created one")
 			ipCidrName = "overlap-cidr"

internal/controllers/ipclaim_controller_test.go

@@ -21,20 +21,20 @@ var _ = Describe("IPClaim controller", func() {
 			ipcidr := getIpCidr(ipClaimCidr, "172.16.0.0/16")
 			Expect(k8sClient.Create(ctx, ipcidr)).Should(Succeed())
 
-			By("Creating a new IPClaim with bad prefix")
+			By("Creating a new IPClaim to claim an IP addr")
 			ipClaimName := "test-ip"
 			ipclaim := getIPClaim("IP", false, ipClaimName, ipClaimCidr)
 			Expect(k8sClient.Create(ctx, ipclaim)).Should(Succeed())
 
 			By("Checking if the 'registered' status field is set to 'true'")
 			ipClaimLookupKey := types.NamespacedName{Name: ipClaimName}
-			claimedIP := &ipamv1alpha1.IPClaim{}
+			ipClaimCR := &ipamv1alpha1.IPClaim{}
 			Eventually(func() (bool, error) {
-				err := k8sClient.Get(ctx, ipClaimLookupKey, claimedIP)
+				err := k8sClient.Get(ctx, ipClaimLookupKey, ipClaimCR)
 				if err != nil {
 					return false, err
 				}
-				return claimedIP.Status.Registered, nil
+				return ipClaimCR.Status.Registered, nil
 			}, timeout, interval).Should(Equal(true))
 		})
 	})