Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Multiple Routes with same path #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allowing Multiple Routes with same path #33

wants to merge 2 commits into from

Conversation

glassresistor
Copy link

Ok this works and contains the updated dist file.

FYI you don't need do to the dist file thing for npm src/index.js should be sufficient to be required.

@Raynos
Copy link
Collaborator

Raynos commented Oct 30, 2014

I don't want to change the public interface of this module.

@glassresistor
Copy link
Author

That makes sense. If you haven't documented the fact that you can't have
two routes without the same path or added an Error/Warn on adding routes
when they are repeated.
I'm going to do some cleanup eventually and put it in npm again under a
different name(your welcome to name it), purely because i think your
implementation is very good in general but using the same path is a pattern
i currently need.
I can link you to progress if you want otherwise I'll not bother you.

On Wed, Oct 29, 2014 at 6:08 PM, Raynos (Jake Verbaten) <
[email protected]> wrote:

I don't want to change the public interface of this module.


Reply to this email directly or view it on GitHub
#33 (comment)
.

Mikela

@Raynos
Copy link
Collaborator

Raynos commented Oct 30, 2014

@glassresistor If you want to make a PR to update the documentation with known caveats and a link to your implementation that works around it then 👍 will merge :)

@glassresistor
Copy link
Author

That sounds really good. I'll let you know thanks.

On Thu, Oct 30, 2014 at 2:09 PM, Raynos (Jake Verbaten) <
[email protected]> wrote:

@glassresistor https://github.com/glassresistor If you want to make a
PR to update the documentation with known caveats and a link to your
implementation that works around it then [image: 👍] will merge :)


Reply to this email directly or view it on GitHub
#33 (comment)
.

Mikela

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants