Merge pull request #5 from aaronLab/feature/remove-oncommitted

Remove onCommitted
aaronlab · Dec 19, 2020 · b51445b · b51445b
2 parents 16cbf2c + 219fc8d
commit b51445b
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 24 deletions.
diff --git a/Example/Example/ContentView.swift b/Example/Example/ContentView.swift
@@ -27,8 +27,6 @@ struct ContentView: View {
                     .font(.system(size: 14, weight: .bold, design: .default))
                 RespondableTextField(text: $text1, tag: 0, isFirstResponder: true, placeholder: "1st") { value in
                     print("onEditing: \(value)")
-                } onCommitted: {
-                    print("onCommitted")
                 } didBeginEditing: {
                     print("didBeginEditing")
                 } didEndEditing: {
@@ -44,8 +42,6 @@ struct ContentView: View {
                     .font(.system(size: 14, weight: .bold, design: .default))
                 RespondableTextField(text: $text2, tag: 1, placeholder: "2nd") { value in
                     print("onEditing: \(value)")
-                } onCommitted: {
-                    print("onCommitted")
                 } didBeginEditing: {
                     print("didBeginEditing")
                 } didEndEditing: {
@@ -63,8 +59,6 @@ struct ContentView: View {
                     .font(.system(size: 14, weight: .bold, design: .default))
                 RespondableTextField(text: $text3, tag: 2, placeholder: "3rd") { value in
                     print("onEditing: \(value)")
-                } onCommitted: {
-                    print("onCommitted")
                 } didBeginEditing: {
                     print("didBeginEditing")
                 } didEndEditing: {
@@ -83,8 +77,6 @@ struct ContentView: View {
                     .font(.system(size: 14, weight: .bold, design: .default))
                 RespondableTextField(text: $text4, tag: 3, placeholder: "4th") { value in
                     print("onEditing: \(value)")
-                } onCommitted: {
-                    print("onCommitted")
                 } didBeginEditing: {
                     print("didBeginEditing")
                 } didEndEditing: {

diff --git a/README.md b/README.md
@@ -34,7 +34,6 @@
     isFirstResponder: Bool = false,
     placeholder: String? = nil,
     onEditing: ((String) -> Void)? = nil,
-    onCommitted: (() -> Void)? = nil,
     didBeginEditing: (() -> Void)? = nil,
     didEndEditing: (() -> Void)? = nil
   )
@@ -77,8 +76,6 @@ struct ContentView: View {
                     .font(.system(size: 14, weight: .bold, design: .default))
                 RespondableTextField(text: $text1, tag: 0, isFirstResponder: true, placeholder: "1st") { value in
                     print("onEditing: \(value)")
-                } onCommitted: {
-                    print("onCommitted")
                 } didBeginEditing: {
                     print("didBeginEditing")
                 } didEndEditing: {
@@ -94,8 +91,6 @@ struct ContentView: View {
                     .font(.system(size: 14, weight: .bold, design: .default))
                 RespondableTextField(text: $text2, tag: 1, placeholder: "2nd") { value in
                     print("onEditing: \(value)")
-                } onCommitted: {
-                    print("onCommitted")
                 } didBeginEditing: {
                     print("didBeginEditing")
                 } didEndEditing: {
@@ -113,8 +108,6 @@ struct ContentView: View {
                     .font(.system(size: 14, weight: .bold, design: .default))
                 RespondableTextField(text: $text3, tag: 2, placeholder: "3rd") { value in
                     print("onEditing: \(value)")
-                } onCommitted: {
-                    print("onCommitted")
                 } didBeginEditing: {
                     print("didBeginEditing")
                 } didEndEditing: {
@@ -133,8 +126,6 @@ struct ContentView: View {
                     .font(.system(size: 14, weight: .bold, design: .default))
                 RespondableTextField(text: $text4, tag: 3, placeholder: "4th") { value in
                     print("onEditing: \(value)")
-                } onCommitted: {
-                    print("onCommitted")
                 } didBeginEditing: {
                     print("didBeginEditing")
                 } didEndEditing: {

diff --git a/Sources/RespondableTextField/RespondableTextField.swift b/Sources/RespondableTextField/RespondableTextField.swift
@@ -19,7 +19,6 @@ public struct RespondableTextField: UIViewRepresentable {
     let tag: Int
     let placeholder: String?
     let onEditing: ((String) -> Void)?
-    let onCommitted: (() -> Void)?
     let didBeginEditing: (() -> Void)?
     let didEndEditing: (() -> Void)?
 
@@ -31,7 +30,6 @@ public struct RespondableTextField: UIViewRepresentable {
         isFirstResponder: Bool = false,
         placeholder: String? = nil,
         onEditing: ((String) -> Void)? = nil,
-        onCommitted: (() -> Void)? = nil,
         didBeginEditing: (() -> Void)? = nil,
         didEndEditing: (() -> Void)? = nil
     ) {
@@ -40,7 +38,6 @@ public struct RespondableTextField: UIViewRepresentable {
         self.isFirstResponder = isFirstResponder
         self.placeholder = placeholder
         self.onEditing = onEditing
-        self.onCommitted = onCommitted
         self.didBeginEditing = didBeginEditing
         self.didEndEditing = didEndEditing
     }
@@ -72,7 +69,7 @@ public struct RespondableTextField: UIViewRepresentable {
 extension RespondableTextField {
 
     public func makeCoordinator() -> RespondableTextField.Coordinator {
-        return Coordinator(text: $text, tag: tag, isFirstResponder: isFirstResponder, placeholder: placeholder, onEditing: onEditing, onCommitted: onCommitted, didBeginEditing: didBeginEditing, didEndEditing: didEndEditing)
+        return Coordinator(text: $text, tag: tag, isFirstResponder: isFirstResponder, placeholder: placeholder, onEditing: onEditing, didBeginEditing: didBeginEditing, didEndEditing: didEndEditing)
     }
 
     public class Coordinator: NSObject, UITextFieldDelegate {
@@ -85,7 +82,6 @@ extension RespondableTextField {
         var didBecomeFirstResponder = false
         let placeholder: String?
         let onEditing: ((String) -> Void)?
-        let onCommitted: (() -> Void)?
         let didBeginEditing: (() -> Void)?
         let didEndEditing: (() -> Void)?
 
@@ -97,7 +93,6 @@ extension RespondableTextField {
             isFirstResponder: Bool = false,
             placeholder: String? = nil,
             onEditing: ((String) -> Void)? = nil,
-            onCommitted: (() -> Void)? = nil,
             didBeginEditing: (() -> Void)? = nil,
             didEndEditing: (() -> Void)? = nil
         ) {
@@ -106,7 +101,6 @@ extension RespondableTextField {
             self.isFirstResponder = isFirstResponder
             self.placeholder = placeholder
             self.onEditing = onEditing
-            self.onCommitted = onCommitted
             self.didBeginEditing = didBeginEditing
             self.didEndEditing = didEndEditing
         }