Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding location header in 302 Redirect Response #136 #139

Closed
wants to merge 1 commit into from

Conversation

yusefren
Copy link

@yusefren yusefren commented Apr 3, 2024

This pull request addresses #136 issue where Location headers were being added to the response when performing a 302 redirect. The expected behaviour is to have the Location header with the correct redirection URL.

Changes:

  • Modified the logic to set the Location header value directly using Headers[header] = values, ensuring that only the last value of the Location header is set in the response.
  • Added a new test case Redirects302ToCorrectLocation in CustomHeaderTests to verify that the 302 redirect response contains Location header with the correct value.

@aaronpowell
Copy link
Owner

Superseded by #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants