Re-enabling ARM containers as the issue is fixed in .NET 8 IIRC #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarathkrishnamurthy
approved these changes
Aug 14, 2024
| @@ -1,11 +1,11 @@ | |||
| #See https://aka.ms/containerfastmode to understand how Visual Studio uses this Dockerfile to build your images for faster debugging. | |||
|
|
|||
| FROM mcr.microsoft.com/dotnet/aspnet:8.0 AS base | |||
| FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:8.0 AS base | |||
There was a problem hiding this comment.
removing --platform=$BUILDPLATFORM have made it work for arm64 images. Please see the suggestion here dotnet/dotnet-docker#5041 . I also tried it out by forking your repo and tested it here https://github.com/sarathkrishnamurthy/httpstatus/pull/1/files#diff-bad1646173d8a455b51286df9ee5a0b27991e22036399c8fa71f7d1c9fa4130cR3
There was a problem hiding this comment.
Hello @aaronpowell , do we have any update on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145