feat: cleanup #73
Merged
feat: cleanup #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sakulstra
commented
Nov 14, 2024
•
sakulstra
commented
- remove paraswap fee claimer as it's no longer used (avara interface was the only one using and it no longer is necessary to have a middle contract with psp v6 aave/interface@68fec1e#diff-5866e66fcd5a4ac26049b83ba47b15d94a9ff6f1a7c117f28d366607a857d0a6R76)
- move static-a-token to stata-token for consistent naming
- add pool and pool address providers to the stata interface
- change the comment action to use the bgd one, so it's easier to iterate without having to update origin (e.g. the correct one has problems with comment size - which is now fixed on bgd side)
- disable certora ci on fork prs as it's only failing anyways
forge 0.0.2 (48c6b1a 2024-11-15T00:25:27.138557582Z)🔧 Build logsCompiling 396 files with Solc 0.8.20
Solc 0.8.20 finished in 101.92s
Compiler run successful with warnings:
Warning (9302): Return value of low-level calls not used.
--> src/contracts/treasury/RevenueSplitter.sol:68:5:
|
68 | RECIPIENT_A.call{value: amount_A}('');
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning (9302): Return value of low-level calls not used.
--> src/contracts/treasury/RevenueSplitter.sol:69:5:
|
69 | RECIPIENT_B.call{value: amount_B}('');
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning (5740): Unreachable code.
--> src/contracts/dependencies/openzeppelin/ReentrancyGuard.sol:61:5:
|
61 | _status = _NOT_ENTERED;
| ^^^^^^^^^^^^^^^^^^^^^^
Warning (2072): Unused local variable.
--> tests/extensions/stata-token/StataTokenV2Rescuable.sol:47:5:
|
47 | address treasury = IAToken(aToken).RESERVE_TREASURY_ADDRESS();
| ^^^^^^^^^^^^^^^^
| Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|------------------------------------------------|------------------|-------------------|--------------------|---------------------|
| ACLManager | 3,493 | 4,107 | 21,083 | 45,045 |
| ATokenInstance | 10,163 | 11,058 | 14,413 | 38,094 |
| ATokenMock | 803 | 967 | 23,773 | 48,185 |
| AaveOracle | 2,662 | 3,867 | 21,914 | 45,285 |
| AaveProtocolDataProvider | 9,465 | 9,739 | 15,111 | 39,413 |
| AaveV3BatchOrchestration | 44 | 94 | 24,532 | 49,058 |
| AaveV3ConfigEngine | 7,573 | 9,165 | 17,003 | 39,987 |
| AaveV3DefaultRateStrategyProcedure | 21 | 47 | 24,555 | 49,105 |
| AaveV3GettersBatchOne | 229 | 32,561 | 24,347 | 16,591 |
| AaveV3GettersBatchTwo | 137 | 11,156 | 24,439 | 37,996 |
| AaveV3GettersProcedureOne | 21 | 47 | 24,555 | 49,105 |
| AaveV3GettersProcedureTwo | 21 | 47 | 24,555 | 49,105 |
| AaveV3HelpersBatchOne | 353 | 34,075 | 24,223 | 15,077 |
| AaveV3HelpersBatchTwo | 229 | 32,983 | 24,347 | 16,169 |
| AaveV3HelpersProcedureOne | 21 | 47 | 24,555 | 49,105 |
| AaveV3HelpersProcedureTwo | 21 | 47 | 24,555 | 49,105 |
| AaveV3IncentiveProcedure | 21 | 47 | 24,555 | 49,105 |
| AaveV3L2PoolBatch | 137 | 43,953 | 24,439 | 5,199 |
| AaveV3L2PoolProcedure | 21 | 47 | 24,555 | 49,105 |
| AaveV3LibrariesBatch1 | 353 | 31,273 | 24,223 | 17,879 |
| AaveV3LibrariesBatch2 | 353 | 41,668 | 24,223 | 7,484 |
| AaveV3MiscBatch | 137 | 6,830 | 24,439 | 42,322 |
| AaveV3MiscProcedure | 21 | 47 | 24,555 | 49,105 |
| AaveV3MockAssetEModeUpdate | 3,420 | 3,649 | 21,156 | 45,503 |
| AaveV3MockBorrowUpdate | 3,300 | 3,491 | 21,276 | 45,661 |
| AaveV3MockBorrowUpdateNoChange | 3,330 | 3,521 | 21,246 | 45,631 |
| AaveV3MockCapUpdate | 3,244 | 3,435 | 21,332 | 45,717 |
| AaveV3MockCollateralUpdate | 3,304 | 3,495 | 21,272 | 45,657 |
| AaveV3MockCollateralUpdateCorrectBonus | 3,304 | 3,495 | 21,272 | 45,657 |
| AaveV3MockCollateralUpdateNoChange | 3,331 | 3,522 | 21,245 | 45,630 |
| AaveV3MockCollateralUpdateWrongBonus | 3,308 | 3,499 | 21,268 | 45,653 |
| AaveV3MockEModeCategoryUpdate | 3,159 | 3,297 | 21,417 | 45,855 |
| AaveV3MockEModeCategoryUpdateEdgeBonus | 3,162 | 3,300 | 21,414 | 45,852 |
| AaveV3MockEModeCategoryUpdateNoChange | 3,221 | 3,359 | 21,355 | 45,793 |
| AaveV3MockListing | 3,598 | 3,827 | 20,978 | 45,325 |
| AaveV3MockListingCustom | 3,891 | 4,203 | 20,685 | 44,949 |
| AaveV3MockPriceFeedUpdate | 3,269 | 3,498 | 21,307 | 45,654 |
| AaveV3MockRatesUpdate | 3,262 | 3,453 | 21,314 | 45,699 |
| AaveV3OracleProcedure | 21 | 47 | 24,555 | 49,105 |
| AaveV3ParaswapBatch | 189 | 30,420 | 24,387 | 18,732 |
| AaveV3ParaswapProcedure | 21 | 47 | 24,555 | 49,105 |
| AaveV3PeripheryBatch | 321 | 40,108 | 24,255 | 9,044 |
| AaveV3PoolBatch | 137 | 42,706 | 24,439 | 6,446 |
| AaveV3PoolConfigProcedure | 21 | 47 | 24,555 | 49,105 |
| AaveV3PoolProcedure | 21 | 47 | 24,555 | 49,105 |
| AaveV3SetupBatch | 11,678 | 25,007 | 12,898 | 24,145 |
| AaveV3SetupProcedure | 21 | 47 | 24,555 | 49,105 |
| AaveV3TestListing | 4,977 | 12,409 | 19,599 | 36,743 |
| AaveV3TokensBatch | 137 | 20,321 | 24,439 | 28,831 |
| AaveV3TokensProcedure | 21 | 47 | 24,555 | 49,105 |
| AaveV3TreasuryProcedure | 21 | 47 | 24,555 | 49,105 |
| Address | 44 | 94 | 24,532 | 49,058 |
| AdminUpgradeabilityProxy | 1,544 | 2,502 | 23,032 | 46,650 |
| AugustusRegistryMock | 162 | 190 | 24,414 | 48,962 |
| BaseAdminUpgradeabilityProxy | 1,536 | 1,565 | 23,040 | 47,587 |
| BaseImmutableAdminUpgradeabilityProxy | 1,302 | 1,469 | 23,274 | 47,683 |
| BaseUpgradeabilityProxy | 108 | 135 | 24,468 | 49,017 |
| BorrowEngine | 2,526 | 2,579 | 22,050 | 46,573 |
| BorrowLogic | 12,405 | 12,458 | 12,171 | 36,694 |
| BridgeLogic | 6,711 | 6,764 | 17,865 | 42,388 |
| CalldataLogic | 44 | 94 | 24,532 | 49,058 |
| CapsEngine | 1,179 | 1,232 | 23,397 | 47,920 |
| CollateralEngine | 2,723 | 2,776 | 21,853 | 46,376 |
| Collector | 6,815 | 6,852 | 17,761 | 42,300 |
| ConfiguratorInputTypes | 44 | 94 | 24,532 | 49,058 |
| ConfiguratorLogic | 6,539 | 6,592 | 18,037 | 42,560 |
| Create2Utils | 121 | 172 | 24,455 | 48,980 |
| DataTypes | 44 | 94 | 24,532 | 49,058 |
| DefaultMarketInput | 21 | 47 | 24,555 | 49,105 |
| DefaultReserveInterestRateStrategyV2 | 3,997 | 4,291 | 20,579 | 44,861 |
| DeployUtils | 913 | 942 | 23,663 | 48,210 |
| ECDSA | 44 | 94 | 24,532 | 49,058 |
| EIP712SigUtils | 1,563 | 1,616 | 23,013 | 47,536 |
| EModeConfiguration | 44 | 94 | 24,532 | 49,058 |
| EModeEngine | 4,485 | 4,538 | 20,091 | 44,614 |
| EModeLogic | 3,756 | 3,809 | 20,820 | 45,343 |
| ERC1967Proxy | 129 | 1,179 | 24,447 | 47,973 |
| ERC20 | 2,085 | 2,833 | 22,491 | 46,319 |
| EmissionManager | 3,455 | 3,916 | 21,121 | 45,236 |
| EngineFlags | 44 | 94 | 24,532 | 49,058 |
| Errors | 4,464 | 4,517 | 20,112 | 44,635 |
| Faucet | 2,064 | 2,596 | 22,512 | 46,556 |
| FlashLoanLogic | 9,520 | 9,573 | 15,056 | 39,579 |
| FlashloanAttacker | 2,123 | 2,547 | 22,453 | 46,605 |
| GPv2SafeERC20 | 44 | 94 | 24,532 | 49,058 |
| GenericLogic | 44 | 94 | 24,532 | 49,058 |
| Initializable | 21 | 47 | 24,555 | 49,105 |
| InitializableAdminUpgradeabilityProxy | 2,388 | 2,417 | 22,188 | 46,735 |
| InitializableImmutableAdminUpgradeabilityProxy | 1,853 | 2,020 | 22,723 | 47,132 |
| InitializableUpgradeabilityProxy | 871 | 900 | 23,705 | 48,252 |
| IsolationModeLogic | 44 | 94 | 24,532 | 49,058 |
| L2Encoder | 3,731 | 3,926 | 20,845 | 45,226 |
| L2PoolInstance | 23,266 | 23,515 | 1,310 | 25,637 |
| LiquidationLogic | 11,787 | 11,840 | 12,789 | 37,312 |
| ListingEngine | 7,156 | 7,209 | 17,420 | 41,943 |
| MarketReportUtils | 44 | 94 | 24,532 | 49,058 |
| Math | 44 | 94 | 24,532 | 49,058 |
| MathUtils | 44 | 94 | 24,532 | 49,058 |
| MathUtilsWrapper | 917 | 946 | 23,659 | 48,206 |
| MessageHashUtils | 44 | 94 | 24,532 | 49,058 |
| MetadataReporter | 12,286 | 12,315 | 12,290 | 36,837 |
| MintableDelegationERC20 | 2,533 | 3,313 | 22,043 | 45,839 |
| MintableERC20 | 3,351 | 4,295 | 21,225 | 44,857 |
| Mock | 182 | 210 | 24,394 | 48,942 |
| MockAToken | 10,165 | 11,062 | 14,411 | 38,090 |
| MockATokenRepayment | 10,246 | 11,143 | 14,330 | 38,009 |
| MockAggregator | 134 | 278 | 24,442 | 48,874 |
| MockBadTransferStrategy | 998 | 1,187 | 23,578 | 47,965 |
| MockERC20AaveLMUpgradeable | 8,401 | 8,626 | 16,175 | 40,526 |
| MockERC4626StataTokenUpgradeable | 9,890 | 10,246 | 14,686 | 38,906 |
| MockFlashLoanATokenReceiver | 2,438 | 2,816 | 22,138 | 46,336 |
| MockFlashLoanReceiver | 2,253 | 2,538 | 22,323 | 46,614 |
| MockFlashLoanSimpleReceiver | 1,476 | 1,761 | 23,100 | 47,391 |
| MockIncentivesController | 132 | 159 | 24,444 | 48,993 |
| MockInitializableFromConstructorImple | 349 | 639 | 24,227 | 48,513 |
| MockInitializableImple | 1,544 | 1,576 | 23,032 | 47,576 |
| MockInitializableImpleV2 | 1,546 | 1,578 | 23,030 | 47,574 |
| MockInitializableV1 | 307 | 339 | 24,269 | 48,813 |
| MockInitializableV2 | 309 | 341 | 24,267 | 48,811 |
| MockL2Pool | 23,293 | 23,542 | 1,283 | 25,610 |
| MockParaSwapAugustus | 2,133 | 3,253 | 22,443 | 45,899 |
| MockParaSwapAugustusRegistry | 179 | 308 | 24,397 | 48,844 |
| MockParaSwapTokenTransferProxy | 905 | 998 | 23,671 | 48,154 |
| MockPeripheryContractV1 | 309 | 338 | 24,267 | 48,814 |
| MockPeripheryContractV2 | 290 | 319 | 24,286 | 48,833 |
| MockPoolInherited | 22,208 | 22,484 | 2,368 | 26,668 |
| MockReentrantInitializableImple | 413 | 445 | 24,163 | 48,707 |
| MockReserveConfiguration | 2,651 | 2,680 | 21,925 | 46,472 |
| MockReserveInterestRateStrategy | 3,314 | 3,612 | 21,262 | 45,540 |
| MockScaledTestnetERC20 | 4,101 | 5,524 | 20,475 | 43,628 |
| MockScaledToken | 3,998 | 4,758 | 20,578 | 44,394 |
| MockVariableDebtToken | 7,281 | 8,162 | 17,295 | 40,990 |
| Ownable | 629 | 722 | 23,947 | 48,430 |
| ParaSwapLiquiditySwapAdapter | 8,733 | 9,850 | 15,843 | 39,302 |
| ParaSwapRepayAdapter | 9,320 | 10,527 | 15,256 | 38,625 |
| ParaSwapWithdrawSwapAdapter | 7,397 | 8,451 | 17,179 | 40,701 |
| PercentageMath | 44 | 94 | 24,532 | 49,058 |
| PercentageMathWrapper | 297 | 326 | 24,279 | 48,826 |
| PoolAddressesProvider | 6,697 | 8,049 | 17,879 | 41,103 |
| PoolAddressesProviderRegistry | 2,148 | 2,609 | 22,428 | 46,543 |
| PoolConfiguratorInstance | 19,780 | 19,812 | 4,796 | 29,340 |
| PoolInstance | 22,019 | 22,268 | 2,557 | 26,884 |
| PoolLogic | 6,823 | 6,876 | 17,753 | 42,276 |
| PoolStorage | 21 | 47 | 24,555 | 49,105 |
| PriceFeedEngine | 1,577 | 1,630 | 22,999 | 47,522 |
| PriceOracle | 469 | 498 | 24,107 | 48,654 |
| PriceOracleSentinel | 1,668 | 1,884 | 22,908 | 47,268 |
| ProxyAdmin | 1,592 | 1,714 | 22,984 | 47,438 |
| ProxyHelpers | 44 | 94 | 24,532 | 49,058 |
| PullRewardsTransferStrategy | 1,255 | 1,481 | 23,321 | 47,671 |
| RateEngine | 2,348 | 2,401 | 22,228 | 46,751 |
| ReserveConfiguration | 128 | 179 | 24,448 | 48,973 |
| ReserveLogic | 44 | 94 | 24,532 | 49,058 |
| RevenueSplitter | 1,942 | 2,259 | 22,634 | 46,893 |
| RewardsController | 14,226 | 14,420 | 10,350 | 34,732 |
| RewardsDataTypes | 44 | 94 | 24,532 | 49,058 |
| SafeCast | 44 | 94 | 24,532 | 49,058 |
| SafeERC20 | 44 | 94 | 24,532 | 49,058 |
| SafeMath | 44 | 94 | 24,532 | 49,058 |
| SequencerOracle | 865 | 1,326 | 23,711 | 47,826 |
| SigUtils | 492 | 545 | 24,084 | 48,607 |
| SignedMath | 44 | 94 | 24,532 | 49,058 |
| SlotParser | 330 | 383 | 24,246 | 48,769 |
| StakeMock | 355 | 384 | 24,221 | 48,768 |
| StakedTokenTransferStrategy | 2,060 | 2,770 | 22,516 | 46,382 |
| StataTokenFactory | 3,562 | 4,053 | 21,014 | 45,099 |
| StataTokenV2 | 19,991 | 20,693 | 4,585 | 28,459 |
| StorageSlot | 44 | 94 | 24,532 | 49,058 |
| Strings | 44 | 94 | 24,532 | 49,058 |
| SupplyLogic | 11,679 | 11,732 | 12,897 | 37,420 |
| TestnetERC20 | 3,981 | 5,396 | 20,595 | 43,756 |
| TransparentProxyFactory | 7,074 | 7,103 | 17,502 | 42,049 |
| TransparentUpgradeableProxy | 2,000 | 3,429 | 22,576 | 45,723 |
| UiIncentiveDataProviderV3 | 9,125 | 9,154 | 15,451 | 39,998 |
| UiPoolDataProviderV3 | 9,917 | 10,128 | 14,659 | 39,024 |
| UpgradeabilityProxy | 108 | 855 | 24,468 | 48,297 |
| UserConfiguration | 44 | 94 | 24,532 | 49,058 |
| ValidationLogic | 189 | 241 | 24,387 | 48,911 |
| VariableDebtTokenHarness | 7,297 | 8,178 | 17,279 | 40,974 |
| VariableDebtTokenInstance | 7,279 | 8,158 | 17,297 | 40,994 |
| WETH9 | 1,885 | 2,354 | 22,691 | 46,798 |
| WETH9Mock | 2,640 | 3,869 | 21,936 | 45,283 |
| WETH9Mocked | 2,191 | 2,660 | 22,385 | 46,492 |
| WadRayMath | 44 | 94 | 24,532 | 49,058 |
| WadRayMathWrapper | 816 | 845 | 23,760 | 48,307 |
| WalletBalanceProvider | 2,619 | 2,648 | 21,957 | 46,504 |
| WalletMock | 21 | 47 | 24,555 | 49,105 |
| WrappedTokenGatewayV3 | 5,722 | 6,600 | 18,854 | 42,552 |⛽ Gas reportWETH9
StataTokenFactory
StataTokenV2
AaveV3ConfigEngine
AaveProtocolDataProvider
ATokenInstance
PoolConfiguratorInstance
PoolInstance
VariableDebtTokenInstance
AaveOracle
DefaultReserveInterestRateStrategyV2
InitializableImmutableAdminUpgradeabilityProxy
MockAggregator
MockParaSwapAugustusRegistry
TestnetERC20
WadRayMathWrapper
ACLManager
PoolAddressesProvider
PoolAddressesProviderRegistry
RewardsController
Collector
RevenueSplitter
AaveV3GettersBatchOne
AaveV3GettersBatchTwo
AaveV3HelpersBatchOne
AaveV3HelpersBatchTwo
AaveV3MiscBatch
AaveV3ParaswapBatch
AaveV3PeripheryBatch
AaveV3PoolBatch
AaveV3SetupBatch
AaveV3TokensBatch
MockERC20AaveLMUpgradeable
MockScaledTestnetERC20
MockERC4626StataTokenUpgradeable
VariableDebtTokenHarness
AaveV3TestListing
🔮 Coverage report
|
|
currently the coverage is truncated - once merged this will be fixed. |
kyzia551
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.