Update sendMessageToL2 function and add AaveStarknetBridgeUpgradePayload contract #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achab
changed the title
achab
changed the title
achab
changed the title
achab
force-pushed
the
feat/upgrade-bridge
branch
from
f0d201e to
5afcf48
Compare
kyzia551
requested changes
Apr 3, 2023
|
|
||
| function execute() external { | ||
| try | ||
| L1_BRIDGE_PROXY.upgradeTo(L1_BRIDGE_NEW_IMPLEMENTATION_ADDRESS) |
There was a problem hiding this comment.
Please put upgradeToAndCall here to update revision
contracts/l1/Bridge.sol
Outdated
| @@ -312,26 +321,29 @@ contract Bridge is IBridge, Initializable { | |||
| (payload[5], payload[6]) = Cairo.toSplitUint(blockNumber); | |||
| (payload[7], payload[8]) = Cairo.toSplitUint(currentRewardsIndex); | |||
|
|
|||
| _messagingContract.sendMessageToL2( | |||
| uint256 nonce; | |||
| (, nonce) = _messagingContract.sendMessageToL2{value: fee}( | |||
There was a problem hiding this comment.
In our opinion, there should be some hard limit of this fee ie, 0.1ETH, and revert in case a user sends more. Because, most likely, it can happen only in the case of some bug.
So I would wrap this logic into some internal function because it is used many times in a code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.