Added ENS Risk Parameters #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ENS to: Lines 27, 60, 87, 110, 134, 158 Need testnet addresses + Tenderly address.
Add ENS Reserve parameters, line 268
Add ENS to lines 254, 284, 375
Add ENS to lines 102, 103
Update reservesConfigs.ts
Update types.ts
Update commons.ts
miguelmtzinf
requested changes
Dec 13, 2021
markets/aave/reservesConfigs.ts
Outdated
| strategy: rateStrategyVolatileFour, | ||
| baseLTVAsCollateral: '5000', | ||
| liquidationThreshold: '6000', | ||
| liquidationBonus: '8000', |
There was a problem hiding this comment.
Liq bonus should be above 100%. A liq bonus of 108% means the liquidator will receive a 8% bonus. This value should be written with 2 zeros, so 10800
Fixed 'liquidationBonus' per comment from @miguelmtzinf
miguelmtzinf
requested changes
Feb 28, 2022
| borrowingEnabled: true, | ||
| stableBorrowRateEnabled: false, | ||
| reserveDecimals: '18', | ||
| aTokenImpl: eContractid.AToken, |
There was a problem hiding this comment.
Please, use DelegationAwareAToken implementation. This will allow the governance to delegate voting power
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.