Skip to content

Commit

Permalink
remove non-working auto merge
Browse files Browse the repository at this point in the history
In k8gb-io#1615 auto merge was enabled for [all non-major dependencies](k8gb-io#1052 (comment)). However, the PR cannot be merged without an approving review.
The missing piece would be the following app: https://github.com/apps/renovate-approve. It would approve all PRs created by the renovate bot that have auto merge enabled. Unfortunately, it cannot do it for projects that have CODEOWNERS setup, which is our case:
> Important note: Due to a GitHub limitation, it is not possible to assign any app like this one as a CODEOWNER, so unfortunately this bot won't work that way if you have CODEOWNERS set up.

Since auto merge does not work this PR removes the configuration to avoid any confusion

Signed-off-by: abaguas <[email protected]>
  • Loading branch information
abaguas committed Jun 28, 2024
1 parent 34bfed6 commit 72c415e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"matchCurrentVersion": "!/^v?0/",
"groupName": "all non-major dependencies",
"groupSlug": "all-minor-patch",
"automerge": true,
}, {
"matchPackageNames": [
"k8gb-io/k8gb",
Expand Down

0 comments on commit 72c415e

Please sign in to comment.