Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring #381

Merged
merged 1 commit into from
Sep 22, 2024
Merged

refactoring #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 67 additions & 59 deletions src/z2ui5_cl_demo_app_000.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
PROTECTED SECTION.
PRIVATE SECTION.

ENDCLASS.
ENDCLASS.



CLASS z2ui5_cl_demo_app_000 IMPLEMENTATION.
CLASS z2ui5_cl_demo_app_000 IMPLEMENTATION.


METHOD z2ui5_if_app~main.
Expand Down Expand Up @@ -210,12 +210,12 @@ CLASS z2ui5_cl_demo_app_000 IMPLEMENTATION.
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel->generic_tile(
header = 'Focus II'
press = client->_event( 'z2ui5_cl_demo_app_189' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).
panel->generic_tile(
header = 'Focus II'
press = client->_event( 'z2ui5_cl_demo_app_189' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel->generic_tile(
header = 'Scrolling'
Expand Down Expand Up @@ -261,13 +261,13 @@ CLASS z2ui5_cl_demo_app_000 IMPLEMENTATION.
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel->generic_tile(
header = 'Session Stickyness II'
subheader = 'Use Locks'
press = client->_event( 'z2ui5_cl_demo_app_135' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).
panel->generic_tile(
header = 'Session Stickyness II'
subheader = 'Use Locks'
press = client->_event( 'z2ui5_cl_demo_app_135' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel = page->panel(
expandable = abap_false
Expand Down Expand Up @@ -299,11 +299,11 @@ CLASS z2ui5_cl_demo_app_000 IMPLEMENTATION.
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel = page->panel(
expandable = abap_false
expanded = abap_true
headertext = `File API`
).
panel = page->panel(
expandable = abap_false
expanded = abap_true
headertext = `File API`
).

panel->generic_tile(
header = 'Download CSV'
Expand Down Expand Up @@ -766,13 +766,13 @@ CLASS z2ui5_cl_demo_app_000 IMPLEMENTATION.
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel->generic_tile(
header = 'Color Picker'
panel->generic_tile(
header = 'Color Picker'
* subheader = 'Token & Range Handling'
press = client->_event( 'z2ui5_cl_demo_app_270' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).
press = client->_event( 'z2ui5_cl_demo_app_270' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel = page->panel(
expandable = abap_false
Expand Down Expand Up @@ -812,11 +812,11 @@ CLASS z2ui5_cl_demo_app_000 IMPLEMENTATION.
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel = page->panel(
expandable = abap_false
expanded = abap_true
headertext = 'Tiles'
).
panel = page->panel(
expandable = abap_false
expanded = abap_true
headertext = 'Tiles'
).

panel->generic_tile(
header = 'Tile'
Expand Down Expand Up @@ -1295,13 +1295,13 @@ CLASS z2ui5_cl_demo_app_000 IMPLEMENTATION.
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel->generic_tile(
header = 'Wizard Control II'
subheader = 'Next step & SubSequentStep'
press = client->_event( 'z2ui5_cl_demo_app_202' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).
panel->generic_tile(
header = 'Wizard Control II'
subheader = 'Next step & SubSequentStep'
press = client->_event( 'z2ui5_cl_demo_app_202' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel->generic_tile(
header = 'Cards'
Expand Down Expand Up @@ -1491,20 +1491,20 @@ CLASS z2ui5_cl_demo_app_000 IMPLEMENTATION.
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel->generic_tile(
header = 'Shell Bar'
subheader = 'title mega menu'
press = client->_event( 'Z2UI5_CL_DEMO_APP_269' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).
panel->generic_tile(
header = 'Shell Bar'
subheader = 'title mega menu'
press = client->_event( 'Z2UI5_CL_DEMO_APP_269' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel->generic_tile(
header = 'Slide Tile'
press = client->_event( 'Z2UI5_CL_DEMO_APP_274' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).
panel->generic_tile(
header = 'Slide Tile'
press = client->_event( 'Z2UI5_CL_DEMO_APP_274' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel = page->panel(
expandable = abap_false
Expand Down Expand Up @@ -1544,13 +1544,13 @@ CLASS z2ui5_cl_demo_app_000 IMPLEMENTATION.
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel->generic_tile(
header = 'Nested Views V'
subheader = 'Sub-App'
press = client->_event( 'Z2UI5_CL_DEMO_APP_104' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).
panel->generic_tile(
header = 'Nested Views V'
subheader = 'Sub-App'
press = client->_event( 'Z2UI5_CL_DEMO_APP_104' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel = page->panel(
expandable = abap_false
Expand Down Expand Up @@ -2010,6 +2010,14 @@ CLASS z2ui5_cl_demo_app_000 IMPLEMENTATION.
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel->generic_tile(
header = 'Date Format Error in internal table'
subheader = ''
press = client->_event( 'Z2UI5_CL_DEMO_APP_118' )
mode = 'LineMode'
class = 'sapUiTinyMarginEnd sapUiTinyMarginBottom'
).

panel = page->panel(
expandable = abap_false
expanded = abap_true
Expand All @@ -2028,4 +2036,4 @@ CLASS z2ui5_cl_demo_app_000 IMPLEMENTATION.
client->view_display( page->stringify( ) ).

ENDMETHOD.
ENDCLASS.
ENDCLASS.
3 changes: 1 addition & 2 deletions src/z2ui5_cl_demo_app_037.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@
z2ui5_on_render( ).

WHEN 'POST'.
DATA(lt_arg) = client->get( )-t_event_arg.
client->message_toast_display( lt_arg[ 1 ] ).
client->message_toast_display( client->get_event_arg( 1 ) ).

Check failure on line 108 in src/z2ui5_cl_demo_app_037.clas.abap

View check run for this annotation

abaplint / abaplint

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

Check failure on line 108 in src/z2ui5_cl_demo_app_037.clas.abap

View check run for this annotation

abaplint / abaplint / abap_cloud_readiness

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

WHEN 'LOAD_CC'.
mv_load_cc = abap_true.
Expand Down
3 changes: 1 addition & 2 deletions src/z2ui5_cl_demo_app_048.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@

CASE client->get( )-event.
WHEN 'EDIT'.
DATA(lt_arg) = client->get( )-t_event_arg.
DATA(lv_row_title) = lt_arg[ 1 ].
DATA(lv_row_title) = client->get_event_arg( 1 ).

Check failure on line 52 in src/z2ui5_cl_demo_app_048.clas.abap

View check run for this annotation

abaplint / abaplint

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

Check failure on line 52 in src/z2ui5_cl_demo_app_048.clas.abap

View check run for this annotation

abaplint / abaplint / abap_cloud_readiness

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax
client->message_box_display( `EDIT - ` && lv_row_title ).
WHEN 'SELCHANGE'.
DATA(lt_sel) = t_tab.
Expand Down
6 changes: 2 additions & 4 deletions src/z2ui5_cl_demo_app_052.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,9 @@
client->popover_destroy( ).

WHEN `POPOVER_DETAIL`.
DATA(lt_arg) = client->get( )-t_event_arg.
DATA(lv_open_by_id) = lt_arg[ 1 ].
mv_check_popover = abap_true.
mv_product = lt_arg[ 2 ].
z2ui5_display_popover( lv_open_by_id ).
mv_product = client->get_event_arg( 2 ).

Check failure on line 119 in src/z2ui5_cl_demo_app_052.clas.abap

View check run for this annotation

abaplint / abaplint

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

Check failure on line 119 in src/z2ui5_cl_demo_app_052.clas.abap

View check run for this annotation

abaplint / abaplint / abap_cloud_readiness

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax
z2ui5_display_popover( client->get_event_arg( 1 ) ).

Check failure on line 120 in src/z2ui5_cl_demo_app_052.clas.abap

View check run for this annotation

abaplint / abaplint

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

Check failure on line 120 in src/z2ui5_cl_demo_app_052.clas.abap

View check run for this annotation

abaplint / abaplint / abap_cloud_readiness

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

WHEN 'BACK'.
client->nav_app_leave( ).
Expand Down
4 changes: 1 addition & 3 deletions src/z2ui5_cl_demo_app_059.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,7 @@

METHOD z2ui5_set_search.

DATA(lt_args) = client->get( )-t_event_arg.
mv_search_value = VALUE #( lt_args[ 1 ] OPTIONAL ).
IF mv_search_value IS INITIAL.
IF client->get_event_arg( 1 ) IS INITIAL.

Check failure on line 91 in src/z2ui5_cl_demo_app_059.clas.abap

View check run for this annotation

abaplint / abaplint

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

Check failure on line 91 in src/z2ui5_cl_demo_app_059.clas.abap

View check run for this annotation

abaplint / abaplint / abap_cloud_readiness

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax
RETURN.
ENDIF.

Expand Down
24 changes: 3 additions & 21 deletions src/z2ui5_cl_demo_app_098.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@
CLASS Z2UI5_CL_DEMO_APP_098 IMPLEMENTATION.


* <SIGNATURE>---------------------------------------------------------------------------------------+
* | Instance Protected Method Z2UI5_CL_DEMO_APP_097->VIEW_DISPLAY_DETAIL
* +-------------------------------------------------------------------------------------------------+
* +--------------------------------------------------------------------------------------</SIGNATURE>
METHOD view_display_detail.

DATA(lo_view_nested) = z2ui5_cl_xml_view=>factory( ).
Expand Down Expand Up @@ -86,10 +82,6 @@
ENDMETHOD.


* <SIGNATURE>---------------------------------------------------------------------------------------+
* | Instance Protected Method Z2UI5_CL_DEMO_APP_097->VIEW_DISPLAY_DETAIL_DETAIL
* +-------------------------------------------------------------------------------------------------+
* +--------------------------------------------------------------------------------------</SIGNATURE>
METHOD view_display_detail_detail.

DATA(lo_view_nested) = z2ui5_cl_xml_view=>factory( ).
Expand All @@ -112,10 +104,6 @@
ENDMETHOD.


* <SIGNATURE>---------------------------------------------------------------------------------------+
* | Instance Protected Method Z2UI5_CL_DEMO_APP_097->VIEW_DISPLAY_MASTER
* +-------------------------------------------------------------------------------------------------+
* +--------------------------------------------------------------------------------------</SIGNATURE>
METHOD view_display_master.

DATA(page) = z2ui5_cl_xml_view=>factory(
Expand Down Expand Up @@ -153,11 +141,6 @@
ENDMETHOD.


* <SIGNATURE>---------------------------------------------------------------------------------------+
* | Instance Public Method Z2UI5_CL_DEMO_APP_097->Z2UI5_IF_APP~MAIN
* +-------------------------------------------------------------------------------------------------+
* | [--->] CLIENT TYPE REF TO Z2UI5_IF_CLIENT
* +--------------------------------------------------------------------------------------</SIGNATURE>
METHOD z2ui5_if_app~main.

me->client = client.
Expand Down Expand Up @@ -185,11 +168,10 @@
CASE client->get( )-event.

WHEN 'ROW_NAVIGATE'.
DATA(lt_arg) = client->get( )-t_event_arg.
READ TABLE lt_arg INTO DATA(ls_arg) INDEX 1.
IF ls_arg IS NOT INITIAL.

IF client->get_event_arg( 1 ) IS NOT INITIAL.

Check failure on line 172 in src/z2ui5_cl_demo_app_098.clas.abap

View check run for this annotation

abaplint / abaplint

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

Check failure on line 172 in src/z2ui5_cl_demo_app_098.clas.abap

View check run for this annotation

abaplint / abaplint / abap_cloud_readiness

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax
mv_layout = `ThreeColumnsEndExpanded`.
mv_title = ls_arg.
mv_title = client->get_event_arg( 1 ).

Check failure on line 174 in src/z2ui5_cl_demo_app_098.clas.abap

View check run for this annotation

abaplint / abaplint

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax

Check failure on line 174 in src/z2ui5_cl_demo_app_098.clas.abap

View check run for this annotation

abaplint / abaplint / abap_cloud_readiness

Method "get_event_arg" not found, methodCallChain 

https://rules.abaplint.org/check_syntax
ENDIF.

client->nest_view_model_update( ).
Expand Down