[채이] 4-ExchangeRate #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaeiJeon
requested review from
11t518s,
dltkdals224,
leehyewon0531,
SaaaHoP and
yoon-junseo
| setResultValue(currencyOneValue, currencyTwoValue); | ||
| } | ||
| function setResultValue(currencyOneValue, currencyTwoValue) { | ||
| fetch(`https://api.exchangerate-api.com/v4/latest/${currencyOneValue}`) |
yoon-junseo
reviewed
Apr 5, 2022
| currencyTwoValue = temp; | ||
| setResultValue(currencyOneValue, currencyTwoValue); | ||
| } | ||
| function setResultValue(currencyOneValue, currencyTwoValue) { |
There was a problem hiding this comment.
callback도 있고, async await으로 할 수도 있을 거 같아요
| } | ||
| function setResultValue(currencyOneValue, currencyTwoValue) { | ||
| fetch(`https://api.exchangerate-api.com/v4/latest/${currencyOneValue}`) | ||
| .then((rest) => rest.json()) |
There was a problem hiding this comment.
rest라고 작성 되어 있는데 res에 대한 오타인지 아니면 일부러 rest로 했는지 궁금해요
| const $swap = document.querySelector("#swap"); | ||
| const $rate = document.querySelector("#rate"); | ||
|
|
||
| $amountOne.addEventListener("change", changeAmountOne); |
There was a problem hiding this comment.
이벤트 리스너를 개인적으로 선언된 함수 아래에 적는게 나을 것 같다고 생각해요!
함수 선언식으로 작성해서 함수들이 호이스팅 되어서 사용 가능한 부분이라서 지금처럼 작성하면 상관 없지만
그래도 함수 선언부 아래에서 호출하는게 나을 것 같다는 개인적인 생각입니다!
https://joshua1988.github.io/web-development/javascript/function-expressions-vs-declarations/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.