Merge pull request Expensify#32166 from dukenv0307/fix/31792

Allow split bill for hidden user
abdel-h66 · Nov 30, 2023 · a6eb7f9 · a6eb7f9
2 parents b9ecec4 + 0a457f4
commit a6eb7f9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/src/components/DisplayNames/index.native.tsx b/src/components/DisplayNames/index.native.tsx
@@ -1,16 +1,18 @@
 import React from 'react';
 import Text from '@components/Text';
+import useLocalize from '@hooks/useLocalize';
 import DisplayNamesProps from './types';
 
 // As we don't have to show tooltips of the Native platform so we simply render the full display names list.
 function DisplayNames({accessibilityLabel, fullTitle, textStyles = [], numberOfLines = 1}: DisplayNamesProps) {
+    const {translate} = useLocalize();
     return (
         <Text
             accessibilityLabel={accessibilityLabel}
             style={textStyles}
             numberOfLines={numberOfLines}
         >
-            {fullTitle}
+            {fullTitle || translate('common.hidden')}
         </Text>
     );
 }

diff --git a/src/components/DisplayNames/index.tsx b/src/components/DisplayNames/index.tsx
@@ -1,23 +1,27 @@
 import React from 'react';
+import useLocalize from '@hooks/useLocalize';
 import DisplayNamesWithoutTooltip from './DisplayNamesWithoutTooltip';
 import DisplayNamesWithToolTip from './DisplayNamesWithTooltip';
 import DisplayNamesProps from './types';
 
 function DisplayNames({fullTitle, tooltipEnabled, textStyles, numberOfLines, shouldUseFullTitle, displayNamesWithTooltips}: DisplayNamesProps) {
+    const {translate} = useLocalize();
+    const title = fullTitle || translate('common.hidden');
+
     if (!tooltipEnabled) {
         return (
             <DisplayNamesWithoutTooltip
                 textStyles={textStyles}
                 numberOfLines={numberOfLines}
-                fullTitle={fullTitle}
+                fullTitle={title}
             />
         );
     }
 
     return (
         <DisplayNamesWithToolTip
             shouldUseFullTitle={shouldUseFullTitle}
-            fullTitle={fullTitle}
+            fullTitle={title}
             displayNamesWithTooltips={displayNamesWithTooltips}
             textStyles={textStyles}
             numberOfLines={numberOfLines}

diff --git a/src/pages/iou/steps/MoneyRequestConfirmPage.js b/src/pages/iou/steps/MoneyRequestConfirmPage.js
@@ -70,13 +70,10 @@ function MoneyRequestConfirmPage(props) {
 
     const participants = useMemo(
         () =>
-            _.chain(props.iou.participants)
-                .map((participant) => {
-                    const isPolicyExpenseChat = lodashGet(participant, 'isPolicyExpenseChat', false);
-                    return isPolicyExpenseChat ? OptionsListUtils.getPolicyExpenseReportOption(participant) : OptionsListUtils.getParticipantsOption(participant, personalDetails);
-                })
-                .filter((participant) => !!participant.login || !!participant.text)
-                .value(),
+            _.map(props.iou.participants, (participant) => {
+                const isPolicyExpenseChat = lodashGet(participant, 'isPolicyExpenseChat', false);
+                return isPolicyExpenseChat ? OptionsListUtils.getPolicyExpenseReportOption(participant) : OptionsListUtils.getParticipantsOption(participant, personalDetails);
+            }),
         [props.iou.participants, personalDetails],
     );
     const isPolicyExpenseChat = useMemo(() => ReportUtils.isPolicyExpenseChat(ReportUtils.getRootParentReport(props.report)), [props.report]);