Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SlackMessageEventEdited include original message's id #226

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

shantanuraj
Copy link
Contributor

What does this PR do?

  • Fix struct to correctly parse current event's ts and edited message's ts property.
    • I needed the original message ts to reconcile it correctly in my datastore.
  • Add parse test.
  • Haven't included the previous_message field in the updated type defintion because I couldn't find public documentation about it, but it seems to be present in the payload for change events.

Closes #224

- Add parse test
- Haven't included the `previous_message` field in the updated
  type defintion because I couldn't find public documentation
  about it, but it seems to be present in the payload for change
  events

Closes abdolence#224
Copy link
Owner

@abdolence abdolence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and fixing the problem 🚀

@abdolence abdolence merged commit 375f116 into abdolence:master Dec 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message change event parsing is broken
2 participants