Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add stars.add and stars.remove methods #250

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

dax
Copy link
Contributor

@dax dax commented Mar 8, 2024

No description provided.

@abdolence
Copy link
Owner

abdolence commented Mar 9, 2024

Hey, I'm fine with the changes in general, but I wonder if you aware of this update from Slack:

Stars can still be added via stars.add but they can no longer be viewed or interacted with by end-users. Additionally, the star_added event is no longer emitted. We recommend retiring any app functionality that relies on stars APIs.

@dax
Copy link
Contributor Author

dax commented Mar 11, 2024

Yes, I know about the deprecation of stars.
Actually stars.list does not work anymore (ie. it always send a empty list) but we can still receive events for "save for later" (add or remove) items as star_added and star_removed events.

Same, the methods stars.add and stars.remove still work for "save for later" items. Unfortunately, there is no "save for later" public API yet so I will rely on the stars API as long as it works 🤷

Copy link
Owner

@abdolence abdolence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@abdolence abdolence merged commit f0f23ca into abdolence:master Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants