fix "Cannot read property includeInto of undefined" error #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from ES6 conversion)
|
I tested it and it worked for me on win 10 with latest atom. Thanks! |
|
Using branch in my atom and I can't open any CSV files at all once the package is installed. No error messages, it just shows the empty pane. Atom 1.28.2 on macOS 10.13.6 edit: Adding that when double clicking a csv file (default to opening in atom) it creates a separate instance of Atom.app which won't close and has to be killed forcefully |
|
Confirm it is fixing the issue on Mac OS 10.14.1 (18B75) |
|
Feb 21 2019 |
|
Worked for me. |
|
Getting the same error :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error in
pool.jsthat causes an error message "Cannot read property includeInto of undefined" (and no table) to appear when opening csv/tsv files with the Table Editor.It appears that
vm.runInContext()does not return a copy of the class when called with an ES6 class declaration, although it may have returned a copy of the class when called with a coffescript class declaration in the past. This pull request refers to the class at the end of the source code, which causesvm.runInContext()to return the class instead ofundefined. This prevents the error noted above.This fixes issues #100 and #101.