fix: Remove ls & lr from subscription creation on Omni rooms (Roc…

…ketChat#31283)

.changeset/sharp-rings-smash.md

@@ -0,0 +1,6 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+Fixed a problem with the subscription creation on Omnichannel rooms. 
+Rooms were being created as seen, causing sound notifications to not work

apps/meteor/app/livechat/client/startup/notifyUnreadRooms.js

@@ -1,9 +1,8 @@
-import { Users } from '@rocket.chat/models';
 import { Meteor } from 'meteor/meteor';
 import { Tracker } from 'meteor/tracker';
 
 import { CustomSounds } from '../../../custom-sounds/client';
-import { Subscriptions } from '../../../models/client';
+import { Subscriptions, Users } from '../../../models/client';
 import { settings } from '../../../settings/client';
 import { getUserPreference } from '../../../utils/client';
 
@@ -16,17 +15,20 @@ Meteor.startup(() => {
 			return;
 		}
 
-		const subs = await Subscriptions.find({ t: 'l', ls: { $exists: 0 }, open: true }).count();
+		const subs = await Subscriptions.find({ t: 'l', ls: { $exists: false }, open: true }).count();
 		if (subs === 0) {
 			audio && audio.pause();
 			return;
 		}
 
-		const user = await Users.findOne(Meteor.userId(), {
-			projection: {
-				'settings.preferences.newRoomNotification': 1,
+		const user = await Users.findOne(
+			{ _id: Meteor.userId() },
+			{
+				projection: {
+					'settings.preferences.newRoomNotification': 1,
+				},
 			},
-		});
+		);
 
 		const newRoomNotification = getUserPreference(user, 'newRoomNotification');
 

apps/meteor/app/livechat/server/lib/Helper.ts

@@ -257,10 +257,8 @@ export const createLivechatSubscription = async (
 			status,
 		},
 		ts: new Date(),
-		lr: new Date(),
-		ls: new Date(),
 		...(department && { department }),
-	};
+	} as InsertionModel<ISubscription>;
 
 	return Subscriptions.insertOne(subscriptionData);
 };