Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #8

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix flaky test #8

merged 1 commit into from
Sep 30, 2024

Conversation

abicky
Copy link
Owner

@abicky abicky commented Sep 30, 2024

This PR fixes the flaky test "ActiveRecord::DebugErrors::DisplayConnectionOwners#execute when ActiveRecord::LockWaitTimeout occurs displays transactions and processlist."
I suspect there is more than 1 second time delay between the start time of the two threads, and CyclicBarrier is expected to shorten the delay.

This commit fixes the flaky test
"ActiveRecord::DebugErrors::DisplayConnectionOwners#execute when
ActiveRecord::LockWaitTimeout occurs displays transactions and
processlist."
I suspect there is more than 1 second time delay between the start
time of the two threads, and CyclicBarrier shortens the delay.
@abicky abicky merged commit b0e6176 into master Sep 30, 2024
96 checks passed
@abicky abicky deleted the fix-flaky-tests branch September 30, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant