-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message.with(event) method for applying message events to a Message #457
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage Report
File Coverage
|
a3a414c
to
763e8d6
Compare
763e8d6
to
3077270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3077270
to
9623b5a
Compare
Context
CHA-702
Description
Add a new method
with()
onMessage
.message.with(event)
is a convenience method that produces a new Message with the event applied to it. It can be used to easily apply update and delete events to a message.Usage example
When message reactions arrive, this method will also correctly apply reactions events to a message.
Another change is that the demo app now shows deleted messages with an "Edit" button. Since we have always supported what I'll call "restore by edit" it makes sense to show it in the UI, as well as to correctly support showing the messages that have been updated after a delete (previously those update events were ignored, considered out of scope for the chat window).
Checklist
Testing Instructions (Optional)
Read the code including demo app for how it's used.