[ECO-5222] fix: Flutter 3.29 compatibility changes #563
Conversation
WalkthroughThe pull request introduces several updates across configuration and build files in the project. It adds a new entry for Flutter version 3.29.0 in the Changes
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
temporarily deployed
to
staging/pull/563/features
github-actions
bot
temporarily deployed
to
staging/pull/563/dartdoc
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
android/gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jarexample/pubspec.lockis excluded by!**/*.lockpubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (10)
.tool-versions(1 hunks)android/gradle/wrapper/gradle-wrapper.properties(1 hunks)android/gradlew(2 hunks)android/gradlew.bat(0 hunks)android/src/main/java/io/ably/flutter/plugin/AblyFlutter.java(0 hunks)example/.gitignore(1 hunks)example/android/app/build.gradle(3 hunks)example/android/gradle/wrapper/gradle-wrapper.properties(1 hunks)example/android/settings.gradle(1 hunks)example/pubspec.yaml(1 hunks)
💤 Files with no reviewable changes (2)
- android/src/main/java/io/ably/flutter/plugin/AblyFlutter.java
- android/gradlew.bat
✅ Files skipped from review due to trivial changes (2)
- .tool-versions
- example/pubspec.yaml
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: android (29)
- GitHub Check: ios
- GitHub Check: android (24)
- GitHub Check: ios (iPhone 15)
- GitHub Check: android
🔇 Additional comments (8)
android/gradlew (1)
58-58: LGTM! Script updates align with latest Gradle wrapper template.The changes update the source URL to the master branch and properly initialize the APP_NAME and APP_BASE_NAME variables.
Also applies to: 85-86
android/gradle/wrapper/gradle-wrapper.properties (1)
3-3: LGTM! Consistent Gradle version across project.The Gradle version update to 8.10.2 maintains consistency with the example project.
example/.gitignore (1)
36-37: LGTM! Added standard NDK build artifacts to gitignore.The addition of
.cxxto gitignore is appropriate as it contains NDK build artifacts that should not be version controlled.example/android/settings.gradle (2)
21-23: Upgrade Android & Kotlin Plugins and Add Google Services PluginThe updated versions—
com.android.applicationto 8.7.0 andorg.jetbrains.kotlin.androidto 1.8.22—ensure compatibility with Flutter 3.29. Additionally, adding thecom.google.gms.google-servicesplugin (version 4.3.10) aligns with the new service integrations. Verify that any corresponding configurations in the app-level Gradle files are consistent with these plugin updates.
26-26: Confirm Module InclusionThe explicit inclusion of the
:appmodule is correct and maintains the intended project structure.example/android/app/build.gradle (3)
6-6: Add Google Services Plugin in App ConfigurationIntegrating the
com.google.gms.google-servicesplugin here is essential for configuring Google services (e.g., Firebase) within the application. Ensure that this plugin is applied in the correct order relative to other Gradle plugins.
15-16: Enable Core Library DesugaringThe addition of
coreLibraryDesugaringEnabled truein thecompileOptionsblock allows the use of newer Java language features on older Android versions. Please verify that this setting satisfies the project's Java compatibility requirements.
50-50: Include Core Library Desugaring DependencyAdding the dependency
coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.0.3'ensures that desugaring support is available during compilation, enabling modern Java APIs on legacy devices. Confirm that this version works seamlessly with the upgraded Android Gradle Plugin.
ttypic
force-pushed
the
ECO-5222/fix-futter-329
branch
from
b9d10d9 to
df61227
Compare
github-actions
bot
temporarily deployed
to
staging/pull/563/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/563/features
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/flutter_example_app.yaml (1)
35-36: Ensure Consistent Flutter Version Across PlatformsThe Android job’s Flutter version has been updated to "3.29" as expected for Flutter 3.29 compatibility. However, note that the iOS job still uses "3.24". Please confirm if this difference is intentional or whether the iOS job should be updated as well for consistency across your CI environments.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
android/gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jarexample/pubspec.lockis excluded by!**/*.lockpubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (11)
.github/workflows/flutter_example_app.yaml(1 hunks).tool-versions(1 hunks)android/gradle/wrapper/gradle-wrapper.properties(1 hunks)android/gradlew(2 hunks)android/gradlew.bat(0 hunks)android/src/main/java/io/ably/flutter/plugin/AblyFlutter.java(0 hunks)example/.gitignore(1 hunks)example/android/app/build.gradle(3 hunks)example/android/gradle/wrapper/gradle-wrapper.properties(1 hunks)example/android/settings.gradle(1 hunks)example/pubspec.yaml(1 hunks)
💤 Files with no reviewable changes (2)
- android/src/main/java/io/ably/flutter/plugin/AblyFlutter.java
- android/gradlew.bat
🚧 Files skipped from review as they are similar to previous changes (8)
- example/pubspec.yaml
- example/.gitignore
- android/gradle/wrapper/gradle-wrapper.properties
- .tool-versions
- android/gradlew
- example/android/gradle/wrapper/gradle-wrapper.properties
- example/android/app/build.gradle
- example/android/settings.gradle
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: android (29)
- GitHub Check: android (24)
- GitHub Check: ios
- GitHub Check: android
- GitHub Check: ios (iPhone 15)
- specified the latest Flutter version in `.tool-versions` - updated example's app gradle settings and dependencies to support 3.29 - removed `io.flutter.plugin.common.PluginRegistry.Registrar` import
ttypic
force-pushed
the
ECO-5222/fix-futter-329
branch
from
df61227 to
5ce0e09
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
example/android/app/build.gradle (1)
41-44: Release Build ProGuard ConfigurationDefining the ProGuard files in the release build type is a strong approach for code optimization and obfuscation. One note: the trailing comma after
"proguard-rules.pro"may not be necessary in the Gradle DSL and could potentially lead to syntax warnings in some configurations. Consider verifying and removing it if needed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
android/gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jarexample/pubspec.lockis excluded by!**/*.lockpubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (12)
.github/workflows/flutter_example_app.yaml(1 hunks).tool-versions(1 hunks)android/gradle/wrapper/gradle-wrapper.properties(1 hunks)android/gradlew(2 hunks)android/gradlew.bat(0 hunks)android/src/main/java/io/ably/flutter/plugin/AblyFlutter.java(0 hunks)example/.gitignore(1 hunks)example/android/app/build.gradle(4 hunks)example/android/app/proguard-rules.pro(1 hunks)example/android/gradle/wrapper/gradle-wrapper.properties(1 hunks)example/android/settings.gradle(1 hunks)example/pubspec.yaml(1 hunks)
💤 Files with no reviewable changes (2)
- android/gradlew.bat
- android/src/main/java/io/ably/flutter/plugin/AblyFlutter.java
✅ Files skipped from review due to trivial changes (1)
- example/android/app/proguard-rules.pro
🚧 Files skipped from review as they are similar to previous changes (8)
- .tool-versions
- example/.gitignore
- example/pubspec.yaml
- example/android/gradle/wrapper/gradle-wrapper.properties
- .github/workflows/flutter_example_app.yaml
- android/gradle/wrapper/gradle-wrapper.properties
- android/gradlew
- example/android/settings.gradle
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: android (29)
- GitHub Check: android (24)
- GitHub Check: ios
- GitHub Check: android
- GitHub Check: ios (iPhone 15)
🔇 Additional comments (3)
example/android/app/build.gradle (3)
6-6: Google Services Plugin AddedThe addition of
id "com.google.gms.google-services"is appropriate for enabling Google services integrations. Ensure that any associated configuration (e.g., in thesettings.gradlefile) remains consistent with this plugin.
15-16: Enabling Core Library DesugaringEnabling desugaring with
coreLibraryDesugaringEnabled trueundercompileOptionsis a suitable update. This allows the project to use newer Java language features on older Android versions. Verify that any related configurations (like the added dependency) align correctly.
53-54: Core Library Desugaring Dependency AdditionThe inclusion of
coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.0.3'ensures that the desugaring feature is supported by pulling in the proper libraries. Confirm that version2.0.3meets your compatibility requirements across the project.
.tool-versionsio.flutter.plugin.common.PluginRegistry.RegistrarimportSummary by CodeRabbit
New Features
Chores
.cxxto.gitignoreto exclude Android NDK-related files.