This repository was archived by the owner on Jan 7, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Added new fields: action (TM2j) and serial (TM2k). #43
Open
maratal
wants to merge
1
commit into
main
Choose a base branch
from
message-action-and-serial
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -592,6 +592,21 @@ Describes the possible actions members in the presence set can emit. | |
| LEAVE | TP2 | A member who was present has now left the channel. This may be a result of an explicit request to leave or implicitly when detaching from the channel. Alternatively, if a member's connection is abruptly disconnected and they do not resume their connection within a minute, Ably treats this as a leave event as the client is no longer present. | | ||
| UPDATE | TP2 | An already present member has updated their member data. Being notified of member data updates can be very useful, for example, it can be used to update the status of a user when they are typing a message. | | ||
|
||
|
||
## enum MessageAction | ||
|
||
Describes the possible actions message can represent (in order from zero). | ||
|
||
| Enum | Spec | Description | | ||
|---|---|---| | ||
| MESSAGE_UNSET | TM5 | Message was unset. | | ||
| MESSAGE_CREATE | TM5 | Message was created. | | ||
| MESSAGE_UPDATE | TM5 | Message was updated. | | ||
| MESSAGE_DELETE | TM5 | Message was deleted. | | ||
| ANNOTATION_CREATE | TM5 | An annotation to the message was created. | | ||
| ANNOTATION_DELETE | TM5 | An annotation to the message was deleted. | | ||
| META_OCCUPANCY | TM5 | An occupancy data. | | ||
|
||
## class ConnectionDetails | ||
|
||
Contains any constraints a client should adhere to and provides additional metadata about a [`Connection`]{@link Connection}, such as if a request to [`publish()`]{@link RealtimeClient#publish} a message that exceeds the maximum message size should be rejected immediately without communicating with Ably. | ||
|
@@ -636,6 +651,8 @@ Contains an individual message that is sent to, or received from, Ably. | |
| id: String ||| TM2a | A Unique ID assigned by Ably to this message. | | ||
| name: String? ||| TM2g | The event name. | | ||
| timestamp: Time ||| TM2f | Timestamp of when the message was received by Ably, as milliseconds since the Unix epoch. | | ||
| action: MessageAction ||| TM2j | The [`MessageAction`]{@link MessageAction} this message represents. | | ||
| serial: String? ||| TM2k | An opaque string that uniquely identifies the message. | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not optional in the IDL. Also, how is this different to |
||
|
||
## class PresenceMessage | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did these descriptions come from? It's not very clear to me from looking at these how a user of the library is meant to use these actions or the two new
Message
fields.