-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace resource #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the behaviour, and creating, updating and deleting all seem to be working well.
There are several things to fix re error messages though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually found one more issue, the field names are different to the ones that we settled on before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@Morganamilo should we merge this? |
@Morganamilo - When testing the change of a namespace_name. I get issues I updated the test to change the namespace_name in the second step:
It then fails with this: `=== RUN TestAccAblyNamespace
--- FAIL: TestAccAblyNamespace (8.47s)` Could you take a look and figure out why namespace_name update is failing? |
You can't change the name of a namespace, at least from the control API perspective. I guess you could delete the namespace and make a new one if the user sets a different name. Should the provider do this? |
Also @graham-russell could you give your input on the ImportState comment? |
Never mind, missed the link you sent, figuring it out. |
I was just checking this in the UI and was able to change the Namespace id in the UI. I wonder how that works. |
I've implemented this myself and have the same issue even with forcenew. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Also fixes some small issues with the app resource.
Implements #9