Skip to content

Commit

Permalink
Merge pull request pentaho#9018 from ssindhu23/BACKLOG-38436
Browse files Browse the repository at this point in the history
[BACKLOG-38436] Code changes for moving mail-validator-job from core to plugin
  • Loading branch information
peterrinehart authored Sep 19, 2023
2 parents b417f9b + 3648bb1 commit 9d75f73
Show file tree
Hide file tree
Showing 24 changed files with 420 additions and 6 deletions.
13 changes: 13 additions & 0 deletions assemblies/plugins/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
<mqtt-streaming-plugin.version>${project.version}</mqtt-streaming-plugin.version>
<pentaho-s3-vfs-plugin.version>${project.version}</pentaho-s3-vfs-plugin.version>
<pdi-avro-format-plugin.version>${project.version}</pdi-avro-format-plugin.version>
<mail-validator-job-plugin.version>${project.version}</mail-validator-job-plugin.version>
<pentaho-metaverse.version>10.1.0.0-SNAPSHOT</pentaho-metaverse.version>
<pdi-xml-plugin.version>10.1.0.0-SNAPSHOT</pdi-xml-plugin.version>
<pdi-json-plugin.version>10.1.0.0-SNAPSHOT</pdi-json-plugin.version>
Expand Down Expand Up @@ -234,6 +235,18 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.pentaho.di.plugins</groupId>
<artifactId>mail-validator-job-plugins</artifactId>
<version>${mail-validator-job-plugin.version}</version>
<type>zip</type>
<exclusions>
<exclusion>
<groupId>*</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.pentaho.di.plugins</groupId>
<artifactId>yaml-input-plugins</artifactId>
Expand Down
1 change: 0 additions & 1 deletion engine/src/main/resources/kettle-job-entries.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
<job-entry id="EVAL_TABLE_CONTENT"> <description>i18n:org.pentaho.di.job.entry:JobEntry.EvalTableContent.TypeDesc</description> <classname>org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent</classname> <category>i18n:org.pentaho.di.job:JobCategory.Category.Conditions</category> <tooltip>i18n:org.pentaho.di.job.entry:JobEntry.EvalTableContent.Tooltip</tooltip> <iconfile>ui/images/ETC.svg</iconfile> <documentation_url>http://wiki.pentaho.com/display/EAI/Evaluate+rows+number+in+a+table</documentation_url> <cases_url/> <forum_url/> </job-entry>
<job-entry id="SIMPLE_EVAL"> <description>i18n:org.pentaho.di.job.entry:JobEntry.SimpleEval.TypeDesc</description> <classname>org.pentaho.di.job.entries.simpleeval.JobEntrySimpleEval</classname> <category>i18n:org.pentaho.di.job:JobCategory.Category.Conditions</category> <tooltip>i18n:org.pentaho.di.job.entry:JobEntry.SimpleEval.Tooltip</tooltip> <iconfile>ui/images/SEV.svg</iconfile> <documentation_url>http://wiki.pentaho.com/display/EAI/Simple+evaluation+%28Job+Entry%29</documentation_url> <cases_url/> <forum_url/> </job-entry>
<job-entry id="SNMP_TRAP"> <description>i18n:org.pentaho.di.job.entry:JobEntry.SNMPTrap.TypeDesc</description> <classname>org.pentaho.di.job.entries.snmptrap.JobEntrySNMPTrap</classname> <category>i18n:org.pentaho.di.job:JobCategory.Category.Utility</category> <tooltip>i18n:org.pentaho.di.job.entry:JobEntry.SNMPTrap.Tooltip</tooltip> <iconfile>ui/images/SNMP.svg</iconfile> <documentation_url>0P0/Monitoring_System_Performance/Integrate_Pentaho_with_3rd-Party_Monitoring_through_SNMP#Send_Traps_from_PDI_Tools_to_Monitoring_Tool</documentation_url> <cases_url/> <forum_url/> </job-entry>
<job-entry id="MAIL_VALIDATOR,JobCategory.Category.Mail_VALIDATOR"> <description>i18n:org.pentaho.di.job.entry:JobEntry.MailValidator.TypeDesc</description> <classname>org.pentaho.di.job.entries.mailvalidator.JobEntryMailValidator</classname> <category>i18n:org.pentaho.di.job:JobCategory.Category.Mail</category> <tooltip>i18n:org.pentaho.di.job.entry:JobEntry.MailValidator.Tooltip</tooltip> <iconfile>ui/images/MAV.svg</iconfile> <documentation_url>http://wiki.pentaho.com/display/EAI/Mail+Validator</documentation_url> <cases_url/> <forum_url/> </job-entry>
<job-entry id="SYSLOG"> <description>i18n:org.pentaho.di.job.entry:JobEntry.Syslog.TypeDesc</description> <classname>org.pentaho.di.job.entries.syslog.JobEntrySyslog</classname> <category>i18n:org.pentaho.di.job:JobCategory.Category.Utility</category> <tooltip>i18n:org.pentaho.di.job.entry:JobEntry.Syslog.Tooltip</tooltip> <iconfile>ui/images/SYL.svg</iconfile> <documentation_url>http://wiki.pentaho.com/display/EAI/Send+information+using+Syslog</documentation_url> <cases_url/> <forum_url/> </job-entry>
<job-entry id="EVAL_FILES_METRICS"> <description>i18n:org.pentaho.di.job.entry:JobEntry.EvalFilesMetrics.TypeDesc</description> <classname>org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics</classname> <category>i18n:org.pentaho.di.job:JobCategory.Category.Conditions</category> <tooltip>i18n:org.pentaho.di.job.entry:JobEntry.EvalFilesMetrics.Tooltip</tooltip> <iconfile>ui/images/CFS.svg</iconfile> <documentation_url>http://wiki.pentaho.com/display/EAI/Evaluate+files+metrics</documentation_url> <cases_url/> <forum_url/> </job-entry>
<job-entry id="CHECK_FILES_LOCKED"> <description>i18n:org.pentaho.di.job.entry:JobEntry.CheckFilesLocked.TypeDesc</description> <classname>org.pentaho.di.job.entries.checkfilelocked.JobEntryCheckFilesLocked</classname> <category>i18n:org.pentaho.di.job:JobCategory.Category.Conditions</category> <tooltip>i18n:org.pentaho.di.job.entry:JobEntry.CheckFilesLocked.Tooltip</tooltip> <iconfile>ui/images/CFL.svg</iconfile> <documentation_url>http://wiki.pentaho.com/display/EAI/Check+if+file+is+locked</documentation_url> <cases_url/> <forum_url/> </job-entry>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@ JobEntry.SimpleEval.TypeDesc=Simple evaluation
JobEntry.SimpleEval.Tooltip=Evaluate one field or variable
JobEntry.SNMPTrap.TypeDesc=Send SNMP trap
JobEntry.SNMPTrap.Tooltip=Send SNMP trap to a target host
JobEntry.MailValidator.TypeDesc=Mail validator
JobEntry.MailValidator.Tooltip=Check the validity of an email address
JobEntry.FTPSGet.TypeDesc=Get a file with FTPS
JobEntry.FTPSGet.Tooltip=Get a file with FTP secure
JobEntry.FTPSPut.TypeDesc=Upload files to FTPS
Expand Down
1 change: 1 addition & 0 deletions plugins/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ __List of the current core plugins:__
* hl7
* json
* openerp
* mail-validator-job
* palo
* s3csvinput
* sap
Expand Down
58 changes: 58 additions & 0 deletions plugins/mail-validator-job/assemblies/plugin/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.pentaho.di.plugins</groupId>
<artifactId>mail-validator-job-assemblies</artifactId>
<version>10.1.0.0-SNAPSHOT</version>
</parent>


<artifactId>mail-validator-job-plugins</artifactId>
<version>10.1.0.0-SNAPSHOT</version>
<packaging>pom</packaging>

<name>PDI Mail Validator Job Plugins Distribution</name>
<description></description>
<properties>
<resources.directory>${project.basedir}/src/main/resources</resources.directory>
</properties>
<dependencies>
<dependency>
<groupId>org.pentaho.di.plugins</groupId>
<artifactId>mail-validator-job-plugins-impl</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.pentaho.di.plugins</groupId>
<artifactId>mail-validator-job-plugins-ui</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>add-libs</id>
<phase>generate-resources</phase>
<goals>
<goal>copy-dependencies</goal>
</goals>
<configuration>
<outputDirectory>${project.build.directory}/assembly/lib</outputDirectory>
<includeScope>compile</includeScope>
<excludeArtifactIds>mail-validator-job-plugins-impl,mail-validator-job-plugins-ui</excludeArtifactIds>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>

</project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd">
<id>mail-validator-job-plugin</id>
<formats>
<format>zip</format>
</formats>
<baseDirectory>mail-validator-job-plugins</baseDirectory>

<files>
<file>
<source>${project.basedir}/src/main/resources/version.xml</source>
<outputDirectory>.</outputDirectory>
<filtered>true</filtered>
</file>
</files>

<fileSets>
<!-- the staging dir -->
<fileSet>
<directory>${project.build.directory}/assembly</directory>
<outputDirectory>.</outputDirectory>
</fileSet>

<fileSet>
<directory>${resources.directory}</directory>
<outputDirectory>.</outputDirectory>
<filtered>true</filtered>
</fileSet>
</fileSets>

<dependencySets>
<dependencySet>
<outputDirectory>.</outputDirectory>
<includes>
<include>org.pentaho.di.plugins:mail-validator-job-plugins-impl:jar</include>
<include>org.pentaho.di.plugins:mail-validator-job-plugins-ui:jar</include>
</includes>
<useProjectArtifact>false</useProjectArtifact>
</dependencySet>
</dependencySets>
</assembly>
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="UTF-8"?>
<version>${project.version}</version>
22 changes: 22 additions & 0 deletions plugins/mail-validator-job/assemblies/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.pentaho.di.plugins</groupId>
<artifactId>mail-validator-job</artifactId>
<version>10.1.0.0-SNAPSHOT</version>
</parent>

<artifactId>mail-validator-job-assemblies</artifactId>
<version>10.1.0.0-SNAPSHOT</version>
<packaging>pom</packaging>

<name>PDI Mail Validator Job Plugins Assemblies</name>

<modules>
<module>plugin</module>
</modules>
</project>
58 changes: 58 additions & 0 deletions plugins/mail-validator-job/impl/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.pentaho.di.plugins</groupId>
<artifactId>mail-validator-job</artifactId>
<version>10.1.0.0-SNAPSHOT</version>
</parent>

<artifactId>mail-validator-job-plugins-impl</artifactId>
<name>PDI Mail Validator Job Plugins Impl</name>

<dependencies>
<dependency>
<groupId>pentaho-kettle</groupId>
<artifactId>kettle-core</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>pentaho-kettle</groupId>
<artifactId>kettle-engine</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.healthmarketscience.jackcess</groupId>
<artifactId>jackcess</artifactId>
<scope>compile</scope>
</dependency>

<!-- Test dependencies -->
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-all</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
<version>1.3</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>pentaho-kettle</groupId>
<artifactId>kettle-core</artifactId>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>pentaho-kettle</groupId>
<artifactId>kettle-engine</artifactId>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
</dependencies>
</project>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
*
* Pentaho Data Integration
*
* Copyright (C) 2002-2017 by Hitachi Vantara : http://www.pentaho.com
* Copyright (C) 2002-2023 by Hitachi Vantara : http://www.pentaho.com
*
*******************************************************************************
*
Expand All @@ -22,6 +22,7 @@

package org.pentaho.di.job.entries.mailvalidator;

import org.pentaho.di.core.annotations.JobEntry;
import org.pentaho.di.job.entry.validator.AndValidator;
import org.pentaho.di.job.entry.validator.JobEntryValidatorUtils;

Expand Down Expand Up @@ -55,6 +56,12 @@
* @author Samatar
* @since 23-06-2008
*/
@JobEntry( id = "MAIL_VALIDATOR,JobCategory.Category.Mail_VALIDATOR", name = "JobEntry.MailValidator.TypeDesc",
i18nPackageName = "org.pentaho.di.job.entries.mailvalidator",
description = "JobEntry.MailValidator.Tooltip",
categoryDescription = "i18n:org.pentaho.di.job:JobCategory.Category.Mail",
image = "ui/images/MAV.svg",
documentationUrl = "http://wiki.pentaho.com/display/EAI/Mail+Validator" )
public class JobEntryMailValidator extends JobEntryBase implements Cloneable, JobEntryInterface {
private static Class<?> PKG = JobEntryMailValidator.class; // for i18n purposes, needed by Translator2!!

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
JobEntry.MailValidator.TypeDesc=Mail validator
JobEntry.MailValidator.Tooltip=Check the validity of an email address
JobEntryMailValidatorDialog.TimeOutField.Tooltip=In order to perform a SMTP check, PDI will open a socket\n,specify here the timeout.
JobEntryMailValidatorDialog.Title=Mail validator
JobEntryMailValidatorDialog.MailAddress.Tooltip=Email address to check.\nIf you want to check with multiple addresses,\nseparate addresses by space.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
*
* Pentaho Data Integration
*
* Copyright (C) 2002-2018 by Hitachi Vantara : http://www.pentaho.com
* Copyright (C) 2002-2023 by Hitachi Vantara : http://www.pentaho.com
*
*******************************************************************************
*
Expand Down
Loading

0 comments on commit 9d75f73

Please sign in to comment.