NOISSUE - Fix ocsp with sdk #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
SammyOina
previously approved these changes
Nov 20, 2024
dborovcanin
requested changes
Nov 22, 2024
sdk/sdk.go
Outdated
| type CertStatus int | ||
|
|
||
| const ( | ||
| Good CertStatus = iota |
sdk/sdk.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| good = "Good" |
sdk/sdk.go
Outdated
Comment on lines
409
to
431
|
|
||
| var ocspResp *ocsp.Response | ||
|
|
||
| if len(body) != emptyOCSPbody { | ||
| ocspResp, err = ocsp.ParseResponse(body, nil) | ||
| if err != nil { | ||
| return OCSPResponse{}, errors.NewSDKError(err) | ||
| } | ||
| } else { | ||
| return OCSPResponse{ | ||
| Status: CertStatus(Unknown), | ||
| SerialNumber: sn, | ||
| Certificate: nil, | ||
| }, nil | ||
| } | ||
|
|
||
| resp := OCSPResponse{ | ||
| Status: CertStatus(ocspResp.Status), | ||
| SerialNumber: ocspResp.SerialNumber, | ||
| Certificate: ocspResp.Certificate.Raw, | ||
| RevokedAt: &ocspResp.RevokedAt, | ||
| IssuerHash: ocspResp.IssuerHash.String(), | ||
| ProducedAt: &ocspResp.ProducedAt, |
There was a problem hiding this comment.
Suggested change
| var ocspResp *ocsp.Response | |
| if len(body) != emptyOCSPbody { | |
| ocspResp, err = ocsp.ParseResponse(body, nil) | |
| if err != nil { | |
| return OCSPResponse{}, errors.NewSDKError(err) | |
| } | |
| } else { | |
| return OCSPResponse{ | |
| Status: CertStatus(Unknown), | |
| SerialNumber: sn, | |
| Certificate: nil, | |
| }, nil | |
| } | |
| resp := OCSPResponse{ | |
| Status: CertStatus(ocspResp.Status), | |
| SerialNumber: ocspResp.SerialNumber, | |
| Certificate: ocspResp.Certificate.Raw, | |
| RevokedAt: &ocspResp.RevokedAt, | |
| IssuerHash: ocspResp.IssuerHash.String(), | |
| ProducedAt: &ocspResp.ProducedAt, | |
| if len(body) == emptyOCSPbody { | |
| return OCSPResponse{ | |
| Status: CertStatus(Unknown), | |
| SerialNumber: sn, | |
| }, nil | |
| } | |
| r, err := ocsp.ParseResponse(body, nil) | |
| if err != nil { | |
| return OCSPResponse{}, errors.NewSDKError(err) | |
| } | |
| resp := OCSPResponse{ | |
| Status: CertStatus(r.Status), | |
| SerialNumber: r.SerialNumber, | |
| Certificate: r.Certificate.Raw, | |
| RevokedAt: &r.RevokedAt, | |
| IssuerHash: r.IssuerHash.String(), | |
| ProducedAt: &r.ProducedAt, | |
| } | |
| return resp, nil |
Signed-off-by: nyagamunene <[email protected]>
dborovcanin
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a bug fix because it fixes the following issue: it changes how the OCSP request is created and presented while using the SDK.
What does this do?
it changes how the OCSP request is created and presented while using the SDK.
Which issue(s) does this PR fix/relate to?
N/A
Have you included tests for your changes?
No
Did you document any new/modified features?
No
Notes