MG-153 - Add Vault scripts as git subtree #157

JeffMboya · 2024-11-18T05:23:25Z

What does this do?

This PR adds vault scripts as a git subtree in the devops repo

Which issue(s) does this PR fix/relate to?

Resolves Feature: Add Vault scripts as git subtree #153

List any changes that modify/break current functionality

None

Have you included tests for your changes?

No, manually tested

Did you document any new/modified functionality?

Yes

Notes

git-subtree-dir: docker/addons/vault git-subtree-split: 54a134e72f47e51acfbced9a94c1b22e13c3e461

…dons/vault'

Signed-off-by: JeffMboya <[email protected]>

git-subtree-dir: vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

Signed-off-by: JeffMboya <[email protected]>

git-subtree-dir: vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

git-subtree-dir: scripts/vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

…ault'

Signed-off-by: JeffMboya <[email protected]>

git-subtree-dir: scripts/vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

…ault'

Signed-off-by: JeffMboya <[email protected]>

JeffMboya · 2024-11-18T09:13:14Z

@arvindh123 There’s a small issue that needs your input:

Adding the Vault scripts as a subdirectory in the DevOps repository under devops/scripts creates the following structure: devops/scripts/vault/scripts. This happens because, in the Magistrala (MG) repository, the Vault scripts are located under vault/scripts.
In MG, the .env file is located at docker/.env. When the Vault scripts are added as a subtree in the DevOps repository, they are imported as-is from MG. As a result, the scripts expect the .env file to be located at docker/.env, which is not imported. This leads to the following error:
```
scripts/vault/scripts/vault_init.sh: line 36: docker/.env: No such file or directory
```

How should we proceed?

arvindh123 · 2024-11-18T13:25:44Z

@arvindh123 There’s a small issue that needs your input:
Adding the Vault scripts as a subdirectory in the DevOps repository under devops/scripts creates the following structure: devops/scripts/vault/scripts. This happens because, in the Magistrala (MG) repository, the Vault scripts are located under vault/scripts.
In MG, the .env file is located at docker/.env. When the Vault scripts are added as a subtree in the DevOps repository, they are imported as-is from MG. As a result, the scripts expect the .env file to be located at docker/.env, which is not imported. This leads to the following error:
scripts/vault/scripts/vault_init.sh: line 36: docker/.env: No such file or directory
How should we proceed?

I hope we had provision to pass env file via flage --env-file
https://github.com/absmach/magistrala/pull/2387
So please pass customized env file to vault scripts

JeffMboya · 2024-11-19T06:27:44Z

@arvindh123 There’s a small issue that needs your input:
Adding the Vault scripts as a subdirectory in the DevOps repository under devops/scripts creates the following structure: devops/scripts/vault/scripts. This happens because, in the Magistrala (MG) repository, the Vault scripts are located under vault/scripts.
In MG, the .env file is located at docker/.env. When the Vault scripts are added as a subtree in the DevOps repository, they are imported as-is from MG. As a result, the scripts expect the .env file to be located at docker/.env, which is not imported. This leads to the following error:
scripts/vault/scripts/vault_init.sh: line 36: docker/.env: No such file or directory
How should we proceed?
I hope we had provision to pass env file via flage --env-file absmach/magistrala#2387 So please pass customized env file to vault scripts

Yes, we have the provision

Signed-off-by: JeffMboya <[email protected]>

arvindh123

.env can be kept at vault/.env,
The script folder should be exact duplicate of magistrala

arvindh123 · 2024-11-19T10:06:15Z

README.md

+
+Since we have added the `magistrala` Vault directory as a subtree in the `devops` repository, we only include the `docker/addons/vault` directory and its contents in `scripts/vault` directory. We do not include `docker/.env` or other unrelated directories from the `magistrala` repository.
+
+As a result, running the Vault setup scripts from within the `scripts/vault/scripts` directory may throw the following error:


I think it is better to mention only how to run scripts with --env-files

Signed-off-by: JeffMboya <[email protected]>

arvindh123

Do we need docker-compose and vault config files in scripts/vault ?

arvindh123 · 2024-11-19T10:24:39Z

scripts/vault/.env

@@ -40,4 +40,4 @@ MG_VAULT_PKI_INT_CA_ST='PARIS'
 MG_VAULT_PKI_INT_CA_ADDR='5 Av. Anatole'
 MG_VAULT_PKI_INT_CA_PO='75007'
 MG_VAULT_PKI_INT_CLUSTER_PATH=http://localhost
-MG_VAULT_PKI_INT_CLUSTER_AIA_PATH=http://localhost
+MG_VAULT_PKI_INT_CLUSTER_AIA_PATH=http://localhost


Please add new line at end of file

arvindh123 · 2024-11-19T10:26:18Z

scripts/vault/README.md

@@ -45,44 +45,24 @@ When the Vault service is started, some initialization steps need to be done to

 ## Setup

-The following scripts are provided, which work on the running Vault service in Docker.
+The following scripts are provided, which work on the running Vault service from within the `docker/addons/vault/scripts` directory.


This doc is relative to magistrala, may be simply we should point MG vault docs for usage

This doc is relative to magistrala, may be simply we should point MG vault docs for usage

Yes, the README is relative to Magistrala because adding docker/addons/vault as a subtree in the DevOps repository imports content relative to Magistrala. The issue is that when the subtree is updated, it will continue importing files tied to Magistrala. A possible solution is to import docker/addons/vault locally, remove unnecessary files, and then push the filtered contents to GitHub. This way, the DevOps repository only includes the required files.

Signed-off-by: JeffMboya <[email protected]>

JeffMboya · 2024-11-19T10:31:43Z

Do we need docker-compose and vault config files in scripts/vault ?

We do not need it. It's there because we have added all the contents of docker/addons/vault to also get docker/addons/vault/entrypoint.sh

arvindh123 · 2024-11-19T10:40:30Z

Do we need docker-compose and vault config files in scripts/vault ?

We do not need it. It's there because we have added all the contents of docker/addons/vault to also get docker/addons/vault/entrypoint.sh

Then is it possible to remove them and have only vault/scripts ?

Signed-off-by: JeffMboya <[email protected]>

git-subtree-dir: scripts/vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

…ault'

git-subtree-dir: vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

Signed-off-by: JeffMboya <[email protected]>

git-subtree-dir: vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

Signed-off-by: JeffMboya <[email protected]>

git-subtree-dir: scripts/vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

…ault'

Signed-off-by: JeffMboya <[email protected]>

git-subtree-dir: docker/addons/vault/scripts git-subtree-split: d9f3bca47842e392383039b84e6b6e223de79e10

…dons/vault/scripts'

Signed-off-by: JeffMboya <[email protected]>

arvindh123

if these files are no needed scripts/vault/config.hcl, scripts/vault/entrypoint.sh , please remove them.

arvindh123 · 2024-11-19T13:26:48Z

README.md

+To run a Vault setup script, use the `--env-file` option to specify the path to your `.env` file:
+
+```bash
+./<script-name>.sh --env-file <path-to-your-env-file>


Move this part to scripts/vault/Readme.md and add words like refer magistrala vault document (and its link)

Signed-off-by: JeffMboya <[email protected]>

arvindh123 · 2024-11-20T10:57:31Z

README.md

@@ -57,6 +57,20 @@ git push origin <your-branch>

 Replace `<your-branch>` with the branch you are working on.

+### Running Vault Setup Scripts with `--env-file`
+
+To run a Vault setup script, use the `--env-file` option to specify the path to your `.env` file:


@JeffMboya This part is moved scripts/vault/Readme.md , so i think it is no more needed here
What do you think ?

@JeffMboya This part is moved scripts/vault/Readme.md , so i think it is no more needed here What do you think ?

Yes, it should be removed.

Signed-off-by: JeffMboya <[email protected]>

arvindh123 · 2024-11-25T10:54:00Z

scripts/vault/README.md

-## Vault Web UI
-
-If the Vault is setup through `docker/addons/vault`, Then Vault Web UI is accessible by default on `http://localhost:8200/ui`.
+For detailed documentation on the available scripts and their usage, visit the [Vault Addon Documentation](https://github.com/absmach/magistrala/tree/main/docker/addons/vault#readme).


Please add following guide

# Developer Guide: Updating Vault Scripts from Magistrala This guide provides step-by-step instructions to update the Vault scripts in your local Magistrala DevOps repository, sync them with the `main` branch of the Magistrala repository, and create a pull request (PR) to merge the changes. ## Prerequisites Make sure you have the following: - A local clone of the Magistrala DevOps repository. - Access to the Magistrala GitHub repository (`https://github.com/absmach/magistrala.git`). ## Step 1: Create new branch Create a new branch from `master` brach ```bash git checkout -b <your-branch-name> `` Replace `<your-branch-name>` with the name a new branch name. ## Step 2: Add the Magistrala Remote If the Magistrala remote is not already added to your local repository, use the following command to add it: ```bash git remote add -f magistrala https://github.com/absmach/magistrala.git `` ## Step 3: Add Subtree for Vault Scripts If the subtree for the Vault scripts has not been added, execute the following command: ```bash git subtree add --prefix=scripts/vault/scripts magistrala main --squash --prefix=docker/addons/vault/scripts `` - `--prefix=scripts/vault/scripts`: Specifies the target directory in your local repository where the Vault scripts will be added. - `magistrala main`: Refers to the `main` branch of the Magistrala repository. - `--squash`: Combines all commits from the Magistrala `main` branch into a single commit when adding the subtree. ## Step 4: Update Vault Scripts to the Latest Version To update the Vault scripts to the latest version and synchronize with the `main` branch of the Magistrala repository, use the following command: ```bash git subtree pull --prefix=scripts/vault/scripts magistrala main --squash --prefix=docker/addons/vault/scripts `` - This command pulls the latest changes from the `main` branch of the Magistrala repository. - `--squash` creates a single commit for the changes, making the history simpler to manage. ## Step 5: Push Changes and Create a Pull Request After syncing with the Magistrala `main` branch, push the changes to your working branch: ```bash git push origin <your-branch-name> `` Replace `<your-branch-name>` with the name of the branch you're working on. Once the changes are pushed, go to your GitHub repository and create a pull request (PR) to merge the updates. ## Summary of Commands related to Git subtree ### Add Magistrala Remote ```bash git remote add -f magistrala https://github.com/absmach/magistrala.git `` ### Add Subtree for Vault Scripts ```bash git subtree add --prefix=scripts/vault/scripts magistrala main --squash --prefix=docker/addons/vault/scripts `` ### Update Vault Scripts to the Latest ```bash git subtree pull --prefix=scripts/vault/scripts magistrala main --squash --prefix=docker/addons/vault/scripts ``

Signed-off-by: JeffMboya <[email protected]>

arvindh123

Please add following guide 


# Developer Guide: Updating Vault Scripts from Magistrala

This guide provides step-by-step instructions to update the Vault scripts in your local Magistrala DevOps repository, sync them with the `main` branch of the Magistrala repository, and create a pull request (PR) to merge the changes.

## Prerequisites

Make sure you have the following:
- A local clone of the Magistrala DevOps repository.
- Access to the Magistrala GitHub repository (`https://github.com/absmach/magistrala.git`).

## Step 1: Create new branch 

Create a new branch from `master` brach

```bash
git checkout -b <your-branch-name>

Replace <your-branch-name> with the name a new branch name.

Step 2: Add the Magistrala Remote

If the Magistrala remote is not already added to your local repository, use the following command to add it:

git remote add -f magistrala https://github.com/absmach/magistrala.git

Step 3: Add Subtree for Vault Scripts

If the subtree for the Vault scripts has not been added, execute the following command:

git subtree add --prefix=scripts/vault/scripts magistrala main --squash --prefix=docker/addons/vault/scripts

--prefix=scripts/vault/scripts: Specifies the target directory in your local repository where the Vault scripts will be added.
magistrala main: Refers to the main branch of the Magistrala repository.
--squash: Combines all commits from the Magistrala main branch into a single commit when adding the subtree.

Step 4: Update Vault Scripts to the Latest Version

To update the Vault scripts to the latest version and synchronize with the main branch of the Magistrala repository, use the following command:

git subtree pull --prefix=scripts/vault/scripts magistrala main --squash --prefix=docker/addons/vault/scripts

This command pulls the latest changes from the main branch of the Magistrala repository.
--squash creates a single commit for the changes, making the history simpler to manage.

Step 5: Push Changes and Create a Pull Request

After syncing with the Magistrala main branch, push the changes to your working branch:

git push origin <your-branch-name>

Replace <your-branch-name> with the name of the branch you're working on.

Once the changes are pushed, go to your GitHub repository and create a pull request (PR) to merge the updates.

Summary of Commands related to Git subtree

Add Magistrala Remote

git remote add -f magistrala https://github.com/absmach/magistrala.git

Add Subtree for Vault Scripts

git subtree add --prefix=scripts/vault/scripts magistrala main --squash --prefix=docker/addons/vault/scripts

Update Vault Scripts to the Latest

git subtree pull --prefix=scripts/vault/scripts magistrala main --squash --prefix=docker/addons/vault/scripts

arvindh123 · 2024-12-02T15:15:23Z

scripts/vault/README.md

+git checkout -b <your-branch-name>
+``



Suggested change

git checkout -b <your-branch-name>

``

```bash

git checkout -b <your-branch-name>

arvindh123 · 2024-12-02T15:15:32Z

scripts/vault/README.md

-### 4. `vault_set_pki.sh`
+```bash
+git remote add -f magistrala https://github.com/absmach/magistrala.git
+``



Suggested change

arvindh123 · 2024-12-02T15:15:37Z

scripts/vault/README.md

-Environmental variables starting with`MG_VAULT_PKI_INT` in `docker/.env` file are used by `vault_set_pki.sh` to generate intermediate CA.  
+```bash
+git subtree add --prefix=scripts/vault/scripts magistrala main --squash --prefix=docker/addons/vault/scripts
+``



Suggested change

arvindh123 · 2024-12-02T15:15:41Z

scripts/vault/README.md

-To skip enable auth approle step use the following  `vault_create_approle.sh   --skip-enable-approle`
+```bash
+git subtree pull --prefix=scripts/vault/scripts magistrala main --squash --prefix=docker/addons/vault/scripts
+``



Suggested change

arvindh123 · 2024-12-02T15:15:46Z

scripts/vault/README.md

-Requirement: [VAULT CLI](https://developer.hashicorp.com/vault/tutorials/getting-started/getting-started-install)
+```bash
+git push origin <your-branch-name>
+``



Suggested change

arvindh123 · 2024-12-02T15:15:50Z

scripts/vault/README.md

-    token          Interact with tokens
-```
+git remote add -f magistrala https://github.com/absmach/magistrala.git
+``



Suggested change

arvindh123 · 2024-12-02T15:15:54Z

scripts/vault/README.md

+### Add Subtree for Vault Scripts
+```bash
+git subtree add --prefix=scripts/vault/scripts magistrala main --squash --prefix=docker/addons/vault/scripts
+``



Suggested change

JeffMboya added 18 commits November 18, 2024 07:58

Squashed 'docker/addons/vault/' content from commit 54a134e7

8cab8df

git-subtree-dir: docker/addons/vault git-subtree-split: 54a134e72f47e51acfbced9a94c1b22e13c3e461

Merge commit '8cab8df5a1cfd26191442818472cfc8ad0680da6' as 'docker/ad…

aedfbae

…dons/vault'

Remove docker/addons/vault directory

beba5e0

Signed-off-by: JeffMboya <[email protected]>

Remove scripts/vault directory

81356c9

Signed-off-by: JeffMboya <[email protected]>

Squashed 'vault/' content from commit a32634a1e

22f2f60

git-subtree-dir: vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

Merge commit '22f2f6083f30faec72f8fb72f9e7e8107739accf' as 'vault'

25db402

Remove scripts/vault directory

cffc3bb

Signed-off-by: JeffMboya <[email protected]>

Squashed 'vault/' content from commit a32634a1e

eb6f4fc

git-subtree-dir: vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

Merge commit 'eb6f4fc1b399c3db293741619638ac7db06b2d29' as 'vault'

f4df847

Squashed 'scripts/vault/' content from commit a32634a1e

cf5b45d

git-subtree-dir: scripts/vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

Merge commit 'cf5b45de649d9b7df1f8a3711bc527a6bf87158d' as 'scripts/v…

0b8ad42

…ault'

Add vault/scripts directory

ffd46e3

Signed-off-by: JeffMboya <[email protected]>

Delete vault directory

d7314d9

Signed-off-by: JeffMboya <[email protected]>

Squashed 'scripts/vault/' content from commit a32634a1e

04a24ae

git-subtree-dir: scripts/vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

Merge commit '04a24aea9c420f527d7db15cb8a1b863328ce53a' as 'scripts/v…

9c7145a

…ault'

Add scripts/vault directory

cfc0100

Signed-off-by: JeffMboya <[email protected]>

Add .env, vault.md, and efk.sh

8fb2d05

Signed-off-by: JeffMboya <[email protected]>

Add empty line

4f98a62

Signed-off-by: JeffMboya <[email protected]>

JeffMboya added 2 commits November 19, 2024 10:14

Update vault docs

fdfd93f

Signed-off-by: JeffMboya <[email protected]>

Remove git pull command

d05d2a8

Signed-off-by: JeffMboya <[email protected]>

JeffMboya marked this pull request as ready for review November 19, 2024 07:33

arvindh123 requested changes Nov 19, 2024

View reviewed changes

Address comments

fa8adb6

Signed-off-by: JeffMboya <[email protected]>

arvindh123 requested changes Nov 19, 2024

View reviewed changes

Add empty line

483526c

Signed-off-by: JeffMboya <[email protected]>

JeffMboya added 16 commits November 19, 2024 15:12

move .env file

6bb155f

Signed-off-by: JeffMboya <[email protected]>

Squashed 'scripts/vault/' content from commit a32634a1e

7cb578d

git-subtree-dir: scripts/vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

Merge commit '7cb578dbedee70ca0eac10a8c5caed7d8ac53d5c' as 'scripts/v…

4d0aa48

…ault'

Squashed 'vault/' content from commit a32634a1e

1006b1c

git-subtree-dir: vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

Merge commit '1006b1c66b57497784783f6b7414ba136dcf3d11' as 'vault'

fc151d6

move .env file

e60cc9f

Signed-off-by: JeffMboya <[email protected]>

Squashed 'vault/' content from commit a32634a1e

e0b0ce3

git-subtree-dir: vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

Merge commit 'e0b0ce33ba0600d7316f7bc8f2fa451c7b6da9a8' as 'vault'

35e12b4

move .env file

f4f15f1

Signed-off-by: JeffMboya <[email protected]>

Squashed 'scripts/vault/' content from commit a32634a1e

42ab894

git-subtree-dir: scripts/vault git-subtree-split: a32634a1e90508f08a75081b0e595a427d3cbb00

Merge commit '42ab894250fa1bf49f3d8a6a9e89fa3116c56ab8' as 'scripts/v…

3623b16

…ault'

move .env file

ad4361b

Signed-off-by: JeffMboya <[email protected]>

Add efk.sh

4e470fa

Signed-off-by: JeffMboya <[email protected]>

Squashed 'docker/addons/vault/scripts/' content from commit d9f3bca47

b98267d

git-subtree-dir: docker/addons/vault/scripts git-subtree-split: d9f3bca47842e392383039b84e6b6e223de79e10

Merge commit 'b98267df3d82f58f4d30ec7f34fb177f202fe030' as 'docker/ad…

1564491

…dons/vault/scripts'

Remove unnecessary files

ab3f879

Signed-off-by: JeffMboya <[email protected]>

arvindh123 requested changes Nov 19, 2024

View reviewed changes

Address comments

fad3ac7

Signed-off-by: JeffMboya <[email protected]>

arvindh123 requested changes Nov 20, 2024

View reviewed changes

Remove duplicate instructions

36238f0

Signed-off-by: JeffMboya <[email protected]>

arvindh123 requested changes Nov 25, 2024

View reviewed changes

JeffMboya added 6 commits November 28, 2024 08:46

Update README

70b83ae

Signed-off-by: JeffMboya <[email protected]>

Fix users authentication error

ea26149

Signed-off-by: JeffMboya <[email protected]>

Add AMA certs

58a7f37

Signed-off-by: JeffMboya <[email protected]>

Bump chart version

dd608db

Signed-off-by: JeffMboya <[email protected]>

Remove ref to magistrala

33c16cf

Signed-off-by: JeffMboya <[email protected]>

Remove vault config files

735284e

Signed-off-by: JeffMboya <[email protected]>

arvindh123 requested changes Dec 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MG-153 - Add Vault scripts as git subtree #157

MG-153 - Add Vault scripts as git subtree #157

JeffMboya commented Nov 18, 2024 •

edited

Loading

JeffMboya commented Nov 18, 2024

arvindh123 commented Nov 18, 2024

JeffMboya commented Nov 19, 2024

arvindh123 left a comment

arvindh123 Nov 19, 2024

arvindh123 left a comment

arvindh123 Nov 19, 2024 •

edited

Loading

arvindh123 Nov 19, 2024

JeffMboya Nov 19, 2024

JeffMboya commented Nov 19, 2024

arvindh123 commented Nov 19, 2024

arvindh123 left a comment

arvindh123 Nov 19, 2024

arvindh123 Nov 20, 2024

JeffMboya Nov 21, 2024

arvindh123 Nov 25, 2024 •

edited

Loading

arvindh123 left a comment

arvindh123 Dec 2, 2024

arvindh123 Dec 2, 2024

arvindh123 Dec 2, 2024

arvindh123 Dec 2, 2024

arvindh123 Dec 2, 2024

arvindh123 Dec 2, 2024

arvindh123 Dec 2, 2024


		Since we have added the `magistrala` Vault directory as a subtree in the `devops` repository, we only include the `docker/addons/vault` directory and its contents in `scripts/vault` directory. We do not include `docker/.env` or other unrelated directories from the `magistrala` repository.

		As a result, running the Vault setup scripts from within the `scripts/vault/scripts` directory may throw the following error:

MG-153 - Add Vault scripts as git subtree #157

Are you sure you want to change the base?

MG-153 - Add Vault scripts as git subtree #157

Conversation

JeffMboya commented Nov 18, 2024 • edited Loading

What does this do?

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

JeffMboya commented Nov 18, 2024

arvindh123 commented Nov 18, 2024

JeffMboya commented Nov 19, 2024

arvindh123 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arvindh123 left a comment

Choose a reason for hiding this comment

arvindh123 Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JeffMboya commented Nov 19, 2024

arvindh123 commented Nov 19, 2024

arvindh123 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arvindh123 Nov 25, 2024 • edited Loading

Choose a reason for hiding this comment

Please add following guide

arvindh123 left a comment

Choose a reason for hiding this comment

Step 2: Add the Magistrala Remote

Step 3: Add Subtree for Vault Scripts

Step 4: Update Vault Scripts to the Latest Version

Step 5: Push Changes and Create a Pull Request

Summary of Commands related to Git subtree

Add Magistrala Remote

Add Subtree for Vault Scripts

Update Vault Scripts to the Latest

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JeffMboya commented Nov 18, 2024 •

edited

Loading

arvindh123 Nov 19, 2024 •

edited

Loading

arvindh123 Nov 25, 2024 •

edited

Loading