Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

Commit

Permalink
NOISSUE - Fix Prefix magistrala to Binary Names (#67)
Browse files Browse the repository at this point in the history
* fix: update Makefile to prefix magistrala

The Makefile has been updated to generate the binary with a specific name. Now, the binary will be named "magistrala-<service_name>" instead of just "<service_name>". This change will help in better identification and organization of the generated binaries.

* fix: update Dockerfile to reflect correct file names

The Dockerfile has been updated to correctly reflect the file names of the built executables. The "mv" command has been modified to move the correct file to the "/exe" directory. This ensures that the Docker container will have the correct executable file.

Signed-off-by: Rodney Osodo <[email protected]>

* feat(build): update Makefile

Updated the Makefile to use a generic binary name in the build process. Instead of using "magistrala-$(1)" as the binary name, now it uses "$(1)". This change allows for easier customization and avoids hard-coding specific binary names for each service.
Revert Dockerfile to use a generic binary name in the build process. Instead of using "magistrala-$SVC" as the binary name, now it uses "$SVC". This change aligns with the updated Makefile and ensures consistency between the build process and the Docker image.

Signed-off-by: Rodney Osodo <[email protected]>

---------

Signed-off-by: Rodney Osodo <[email protected]>
  • Loading branch information
rodneyosodo authored Nov 21, 2023
1 parent 23618c1 commit 12d4005
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ ifdef pv
endif

install:
cp ${BUILD_DIR}/* $(GOBIN)
for file in $(BUILD_DIR)/*; do \
cp $$file $(GOBIN)/magistrala-`basename $$file`; \
done

test:
go test -mod=vendor -v -race -count 1 -tags test $(shell go list ./... | grep -v 'vendor\|cmd')
Expand Down

0 comments on commit 12d4005

Please sign in to comment.