Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

MG-104: Rename/Replace filed owner to domain #268

Merged
merged 10 commits into from
Jan 27, 2024

Conversation

arvindh123
Copy link
Contributor

@arvindh123 arvindh123 commented Jan 8, 2024

What type of PR is this?

This is a refactor because it changes the following functionality:

  • Rename/Replace filed owner to domain in all services

What does this do?

Which issue(s) does this PR fix/relate to?

  • Resolves absmach/magistrala#1953

Have you included tests for your changes?

Yes, WIP

Did you document any new/modified feature?

Yes, WIP

Notes:
Should be merged after

@arvindh123 arvindh123 force-pushed the MG104_replace_owner_to_domain branch from 5b26bf2 to e5af976 Compare January 25, 2024 13:45
@arvindh123 arvindh123 marked this pull request as ready for review January 25, 2024 17:04
@dborovcanin dborovcanin force-pushed the MG104_replace_owner_to_domain branch from aeb96fb to 5b846c7 Compare January 25, 2024 17:18
@dborovcanin dborovcanin changed the title MG104: Rename/Replace filed owner to domain MG-104: Rename/Replace filed owner to domain Jan 25, 2024
@arvindh123 arvindh123 self-assigned this Jan 25, 2024
@dborovcanin dborovcanin force-pushed the MG104_replace_owner_to_domain branch from 98d0eaa to 69beec8 Compare January 26, 2024 13:02
@@ -382,8 +381,7 @@ paths:
- Channels
summary: Creates new channel
description: |
Creates new channel. User identified by the provided access token will
be the channel's owner.
Creates new channel. Domain identified by the provided access token will.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not fixed.

things/api/http/endpoints_test.go Show resolved Hide resolved
@arvindh123 arvindh123 force-pushed the MG104_replace_owner_to_domain branch from 69beec8 to 2e96434 Compare January 26, 2024 17:13
@dborovcanin dborovcanin merged commit 2c48804 into absmach:main Jan 27, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Replace name from owner field to domain for all entities
2 participants