This repository has been archived by the owner on Oct 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
MG-104: Rename/Replace filed owner to domain #268
Merged
dborovcanin
merged 10 commits into
absmach:main
from
arvindh123:MG104_replace_owner_to_domain
Jan 27, 2024
Merged
MG-104: Rename/Replace filed owner to domain #268
dborovcanin
merged 10 commits into
absmach:main
from
arvindh123:MG104_replace_owner_to_domain
Jan 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindh123
force-pushed
the
MG104_replace_owner_to_domain
branch
from
January 25, 2024 13:45
5b26bf2
to
e5af976
Compare
dborovcanin
force-pushed
the
MG104_replace_owner_to_domain
branch
from
January 25, 2024 17:18
aeb96fb
to
5b846c7
Compare
dborovcanin
changed the title
MG104: Rename/Replace filed owner to domain
MG-104: Rename/Replace filed owner to domain
Jan 25, 2024
dborovcanin
force-pushed
the
MG104_replace_owner_to_domain
branch
from
January 26, 2024 13:02
98d0eaa
to
69beec8
Compare
dborovcanin
suggested changes
Jan 26, 2024
api/openapi/things.yml
Outdated
@@ -382,8 +381,7 @@ paths: | |||
- Channels | |||
summary: Creates new channel | |||
description: | | |||
Creates new channel. User identified by the provided access token will | |||
be the channel's owner. | |||
Creates new channel. Domain identified by the provided access token will. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not fixed.
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
arvindh123
force-pushed
the
MG104_replace_owner_to_domain
branch
from
January 26, 2024 17:13
69beec8
to
2e96434
Compare
dborovcanin
approved these changes
Jan 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor because it changes the following functionality:
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, WIP
Did you document any new/modified feature?
Yes, WIP
Notes:
Should be merged after
pkg/clients
Tests #258