This repository has been archived by the owner on Oct 14, 2024. It is now read-only.
NOISSUE - Replace deprecated instrumentation method #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the gRPC server's UnaryInterceptor with StatsHandler from the otelgrpc package for enhanced monitoring capabilities, aligning with best practices for observability. This update allows us to take full advantage of OpenTelemetry's metrics and traces, thereby improving insight into our gRPC server's performance and reliability. Signed-off-by: SammyOina <[email protected]>
dborovcanin
force-pushed
the
deprecated-grpc
branch
from
94b6449 to
71b897d
Compare
dborovcanin
approved these changes
Jan 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is an update that replaces the unitary grpc interceptor method on grpc options
What does this do?
Replaced the gRPC server's UnaryInterceptor with StatsHandler from the otelgrpc package for enhanced monitoring capabilities, aligning with best practices for observability. This update allows us to take full advantage of OpenTelemetry's metrics and traces, thereby improving insight into our gRPC server's performance and reliability.
Which issue(s) does this PR fix/relate to?
None
Have you included tests for your changes?
No, this does not change functionality or add new methods
Did you document any new/modified feature?
No, no functionality was changed
Notes