This repository has been archived by the owner on Oct 14, 2024. It is now read-only.
NOISSUE - Update Copyright Notice #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
force-pushed
the
license-header
branch
9 times, most recently
from
683029e to
d0e2887
Compare
SammyOina
approved these changes
Nov 14, 2023
rodneyosodo
force-pushed
the
license-header
branch
from
d0e2887 to
a38de3e
Compare
dborovcanin
reviewed
Nov 14, 2023
|
Goheader only does it for go files. |
dborovcanin
suggested changes
Nov 14, 2023
dborovcanin
approved these changes
Nov 14, 2023
rodneyosodo
force-pushed
the
license-header
branch
from
49225a7 to
6c6ce06
Compare
ianmuchyri
approved these changes
Nov 16, 2023
rodneyosodo
force-pushed
the
license-header
branch
3 times, most recently
from
ca7274a to
8103f82
Compare
dborovcanin
suggested changes
Nov 17, 2023
Add CI check for non go files to check that the files contain a license Signed-off-by: Rodney Osodo <[email protected]>
When the CI fails during check for license header, log the failed file to console so that someone can check on the actual file. Also simplify the grep check to make it more human readable and understandable Signed-off-by: Rodney Osodo <[email protected]>
rodneyosodo
force-pushed
the
license-header
branch
from
8103f82 to
0140bc1
Compare
dborovcanin
approved these changes
Nov 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Add CI check for non-go files to check that the files contain a license
Which issue(s) does this PR fix/relate to?
No issue
List any changes that modify/break current functionality
None
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes
N/A