Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

NOISSUE - Fix Users Tests #42

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

rodneyosodo
Copy link
Member

What does this do?

Fix tests in users service to ensure there are no failing tests

Which issue(s) does this PR fix/relate to?

Related to absmach/magistrala#2014

List any changes that modify/break current functionality

None

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

No

Notes

N/A

@rodneyosodo rodneyosodo force-pushed the 11-14-Fix_users_tests branch 5 times, most recently from a5fe742 to 5159ea6 Compare November 20, 2023 13:08
Fix tests in users service to ensure there are no failing tests
Added test cases to cover the authn and authz functionality of the user service with domains integration.  The tests involve mocking function calls, setting up expectations, and checking for expected results. The code includes conditional statements and different scenarios to ensure the proper behavior of the functions.
This commit also fixes updating client secret

Signed-off-by: Rodney Osodo <[email protected]>
Fix bug in loading auth config and also refactor postgres connect
@rodneyosodo rodneyosodo force-pushed the 11-14-Fix_users_tests branch from 05b71e1 to f73fffb Compare November 21, 2023 12:55
Copy link
Contributor

@arvindh123 arvindh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dborovcanin dborovcanin merged commit 1f9d551 into absmach:main Nov 22, 2023
2 checks passed
dborovcanin pushed a commit that referenced this pull request Nov 27, 2023
* NOISSUE - Fix Users Tests (#42)

* Fix users tests

Fix tests in users service to ensure there are no failing tests

* test: update tests with domains

Added test cases to cover the authn and authz functionality of the user service with domains integration.  The tests involve mocking function calls, setting up expectations, and checking for expected results. The code includes conditional statements and different scenarios to ensure the proper behavior of the functions.
This commit also fixes updating client secret

Signed-off-by: Rodney Osodo <[email protected]>

* NOISSUE - Fix loading Auth config (#64)

Fix bug in loading auth config and also refactor postgres connect

---------

Signed-off-by: Rodney Osodo <[email protected]>

* Fix failing tests in SDK

Fix failing tests in `sdk` package.

* fix(tests): update sdk tests with domains

Add domain integration and fix failing tests on SDK package

Signed-off-by: Rodney Osodo <[email protected]>

---------

Signed-off-by: Rodney Osodo <[email protected]>
@rodneyosodo rodneyosodo deleted the 11-14-Fix_users_tests branch December 12, 2023 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants