This repository has been archived by the owner on Oct 14, 2024. It is now read-only.
NOISSUE - Generate Invitation Key #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
force-pushed
the
11-27-feat_auth_Add_invitation_key_generation
branch
5 times, most recently
from
a26f92d to
951aa55
Compare
This commit adds the functionality to generate an invitation key in the auth service. The `invitationKey` function is responsible for generating the key and issuing an access token. It sets the key type, expiration time, and subject based on the user's domain. The generated access token is returned as part of the response. The `invitationKey` function is called in the `Issue` function when the key type is InvitationKey. This allows for the generation of invitation keys when needed. This feature enhances the functionality of the auth service by enabling the generation of invitation keys for user invitations. Signed-off-by: Rodney Osodo <[email protected]>
The invitation duration in the auth service has been corrected to 7 days (7 * 24 * time.Hour) instead of 24 hours. Signed-off-by: Rodney Osodo <[email protected]>
rodneyosodo
force-pushed
the
11-27-feat_auth_Add_invitation_key_generation
branch
from
951aa55 to
41a6832
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage ? 44.06%
=======================================
Files ? 19
Lines ? 817
Branches ? 0
=======================================
Hits ? 360
Misses ? 443
Partials ? 14 ☔ View full report in Codecov by Sentry. |
Configure invitation duration by envionment variables. The default is `168h` which is 1 week.
dborovcanin
approved these changes
Dec 1, 2023
rodneyosodo
deleted the
11-27-feat_auth_Add_invitation_key_generation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This commit adds the functionality to generate an invitation key in the auth service. The
invitationKeyfunction is responsible for generating the key and issuing an access token. It sets the key type, expiration time, and subject based on the user's domain. The generated access token is returned as part of the response.The
invitationKeyfunction is called in theIssuefunction when the key type is InvitationKey. This allows for the generation of invitation keys when needed.This feature enhances the functionality of the auth service by enabling the generation of invitation keys for user invitations.
Which issue(s) does this PR fix/relate to?
No issue
List any changes that modify/break current functionality
None
Have you included tests for your changes?
Not yet
Did you document any new/modified functionality?
No
Notes
Replacement of #80